Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-9987 PR #120239 - db-console: add metrics to network page #18498

Merged
merged 7 commits into from
May 16, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Apr 23, 2024

Fixes DOC-9987, DOC-9986

In ui-networking-dashboard.md, (a) added graphs for v23.2 and v24.1, (b) added section for partial network partitions.

Rendered preview: Networking dashboard

Copy link

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 17706ad
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/664621ea43caa50008b6b5b7

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 17706ad
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/664621eac688dd000867f01d

Copy link

netlify bot commented Apr 23, 2024

Netlify Preview

Name Link
🔨 Latest commit 17706ad
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/664621ea4917e800087ff623
😎 Deploy Preview https://deploy-preview-18498--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@florence-crl florence-crl requested a review from taroface May 1, 2024 14:01
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and tweaks

Note that the comments on 23.2 should equally apply to 24.1

src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!

src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
src/current/v24.1/ui-networking-dashboard.md Outdated Show resolved Hide resolved
@florence-crl florence-crl requested a review from taroface May 7, 2024 14:25
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 nit and 1 question

src/current/v23.2/ui-networking-dashboard.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit 0a22453 into main May 16, 2024
6 checks passed
@florence-crl florence-crl deleted the DOC-9987 branch May 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants