Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-9671 PR #119205 - cli: --include-range-info flag for cockroach debug zip also toggles problem ranges #18512

Merged
merged 3 commits into from
May 6, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented May 1, 2024

Fixes DOC-9671

In cockroach-debug.zip, (a) removed problem ranges from “cannot be filtered list”, (b) updated to description of --include-range-info flag to include problemranges.json.

Rendered preview: cockroach debug zip

…ltered list”, (b) updated to description of --include-range-info flag to include problemranges.json.
Copy link

netlify bot commented May 1, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 66fc855
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66393213ad7ae20008d6742b

Copy link

netlify bot commented May 1, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 66fc855
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/663932137ccd4c00084bd1e5

Copy link

netlify bot commented May 1, 2024

Netlify Preview

Name Link
🔨 Latest commit 66fc855
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/663932135fd5b70008b88adc
😎 Deploy Preview https://deploy-preview-18512--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl florence-crl requested a review from nkodali May 6, 2024 14:03
@florence-crl florence-crl requested a review from taroface May 6, 2024 18:36
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nits

src/current/v23.1/cockroach-debug-zip.md Outdated Show resolved Hide resolved
src/current/v23.2/cockroach-debug-zip.md Outdated Show resolved Hide resolved
src/current/v24.1/cockroach-debug-zip.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit c4e825a into main May 6, 2024
6 checks passed
@florence-crl florence-crl deleted the DOC-9671 branch May 6, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants