[DOC-10097] 24.1 features that require upgrade finalization #18532
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
LGTM with non-blocking suggestions
Suggest getting technical review on this as well. I assume maybe you've had convos elsewhere with engineering team folks re: these are the features that require upgrade finalization? I realize you shared a link to the code but like, idk how to map from the code in that file to what should be in this doc so I'm assuming you do and/or have talked to people who do.
I also looked at old docs PRs for "upgrade finalization" and discovered that a lot of those PRs didn't have eng reviewers so maybe I'm just wrong and it's not necessary? Defer to your expertise in this area ofc but that's just what came to my mind
Thanks. In brief, each line in that section of that file was added by an engineer because their feature requires a migration (and thus, finalization). So we go to the correct area of the file and then use Github's handy Git Blame view to see which commit added each line. From the commit I can get to the PR, where I can read about it and find the engineer who authored it or reviewed it and ask them some questions. That's why I was asking you about protected timestamps earlier. :) |
mdlinville
force-pushed
the
DOC-10097
branch
2 times, most recently
from
1fb48e4
to
cabf98f
Compare
|
LGTM with non-blocking suggestions
Suggest getting technical review on this as well. I assume maybe
you've had convos elsewhere with engineering team folks re: these
are the features that require upgrade finalization? I realize you
shared a link to the code but like, idk how to map from the code
in that file to what should be in this doc so I'm assuming you do
and/or have talked to people who do.
I also looked at old docs PRs for "upgrade finalization" and
discovered that a lot of those PRs didn't have eng reviewers so
maybe I'm just wrong and it's not necessary? Defer to your
expertise in this area ofc but that's just what came to my mind
Thanks. In brief, each line in that section of that file was added by
an engineer because their feature requires a migration (and thus,
finalization). So we go to the correct area of the file and then use
Github's handy Git Blame view to see which commit added each line.
From the commit I can get to the PR, where I can read about it and
find the engineer who authored it or reviewed it and ask them some
questions. That's why I was asking you about protected timestamps
earlier. :)
Makes sense, thanks for explaining this process to me! (I haven't done
it before myself)
|
[DOC-10097] 24.1 features that require upgrade finalization
Src: https://github.com/cockroachdb/cockroach/blob/release-24.1.0-rc/pkg/clusterversion/cockroach_versions.go#L260
Preview
src/current/cockroachcloud/upgrade-to-v24.1.md
src/current/v24.1/upgrade-cockroach-version.md