Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-9723] Update Terraform page for new plans #18916

Merged
merged 4 commits into from
Sep 23, 2024
Merged

[DOC-9723] Update Terraform page for new plans #18916

merged 4 commits into from
Sep 23, 2024

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Sep 16, 2024

[DOC-9723] Update Terraform page for new plans

  • Update page title (but not filename) with an eye toward covering more than cluster creation on the page in future
  • Update page variables and filter tabs
  • Split Serverless into Basic and Standard
  • Removed the tfvars construct in favor of directly copying the examples from https://github.com/cockroachdb/terraform-provider-cockroach/blob/398102111d6e696a4e2c034077f812cd1917f675/examples/resources/cockroach_cluster/resource.tf with the following changes:
    • Replace machine_type field in Advanced example with provisioned_vcpus, per thread.
    • Subsequently replaced provisioned_vcpus with provisioned_virtual_cpus and num_vcpus with num_virtual_cpus, per @andy-kimball
    • Removed output that will necessarily be different from the reader's actual experience and presents maintenance challenges over time, with little benefit to the reader.
  • Restructured Markdown source a bit for ease of maintenance

Out of scope for this PR: Changing from Basic to Standard using Terraform. Coming subsequent to this PR.

Copy link

Files changed:

Copy link

netlify bot commented Sep 16, 2024

Netlify Preview

Name Link
🔨 Latest commit 61c9751
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66f1eb71a1bc8c000808f437
😎 Deploy Preview https://deploy-preview-18916--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andy-kimball
Copy link

LGTM

Copy link
Contributor

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdlinville mdlinville merged commit bfd4d63 into cloud-2.0 Sep 23, 2024
3 of 4 checks passed
@mdlinville mdlinville deleted the DOC-9723 branch September 23, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants