-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC-9723] Update Terraform page for new plans #18916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlinville
requested review from
marksoper,
rgcase,
fantapop and
andy-kimball
September 16, 2024 23:45
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/current/cockroachcloud/provision-a-cluster-with-terraform.md
Outdated
Show resolved
Hide resolved
src/current/cockroachcloud/provision-a-cluster-with-terraform.md
Outdated
Show resolved
Hide resolved
mdlinville
force-pushed
the
DOC-9723
branch
from
September 17, 2024 18:14
37574c2
to
1cd10c3
Compare
LGTM |
and num_virtual_cpus
mdlinville
force-pushed
the
DOC-9723
branch
from
September 17, 2024 18:59
1cd10c3
to
6e9948b
Compare
mikeCRL
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mdlinville
commented
Sep 23, 2024
src/current/cockroachcloud/provision-a-cluster-with-terraform.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DOC-9723] Update Terraform page for new plans
tfvars
construct in favor of directly copying the examples from https://github.com/cockroachdb/terraform-provider-cockroach/blob/398102111d6e696a4e2c034077f812cd1917f675/examples/resources/cockroach_cluster/resource.tf with the following changes:machine_type
field in Advanced example withprovisioned_vcpus
, per thread.provisioned_vcpus
withprovisioned_virtual_cpus
andnum_vcpus
withnum_virtual_cpus
, per @andy-kimballOut of scope for this PR: Changing from Basic to Standard using Terraform. Coming subsequent to this PR.