mixing transaction isolation levels #18929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
michae2
approved these changes
Sep 23, 2024
florence-crl
approved these changes
Sep 27, 2024
Comment on lines
+5
to
+6
| - If a `READ COMMITTED` transaction `R` commits before a `SERIALIZABLE` transaction `S`, every statement in `S` will observe all writes from `R`. Otherwise, `S` will not observe any writes from `R`. | ||
| - If a `SERIALIZABLE` transaction `S` commits before a `READ COMMITTED` transaction `R`, every **subsequent** statement in `R` will observe all writes from `S`. Otherwise, `R` will not observe any writes from `S`. |
There was a problem hiding this comment.
formatting nit, add break tags
Suggested change
| - If a `READ COMMITTED` transaction `R` commits before a `SERIALIZABLE` transaction `S`, every statement in `S` will observe all writes from `R`. Otherwise, `S` will not observe any writes from `R`. | |
| - If a `SERIALIZABLE` transaction `S` commits before a `READ COMMITTED` transaction `R`, every **subsequent** statement in `R` will observe all writes from `S`. Otherwise, `R` will not observe any writes from `S`. | |
| - If a `READ COMMITTED` transaction `R` commits before a `SERIALIZABLE` transaction `S`,<br>every statement in `S` will observe all writes from `R`.<br>Otherwise, `S` will not observe any writes from `R`. | |
| - If a `SERIALIZABLE` transaction `S` commits before a `READ COMMITTED` transaction `R`,<br>every **subsequent** statement in `R` will observe all writes from `S`.<br> Otherwise, `R` will not observe any writes from `S`. |
so it is a bit more readable
Comment on lines
+10
to
+12
| - If a `READ COMMITTED` transaction `R` writes but does not commit before a `SERIALIZABLE` transaction `S`, no statement in `S` will observe or be blocked by any uncommitted writes from `R`. | ||
| - If a `SERIALIZABLE` transaction `S` writes but does not commit before a `READ COMMITTED` transaction `R`, no statement in `R` will observe or be blocked by any uncommitted writes from `S`. | ||
| - If a `SERIALIZABLE` transaction `S1` writes but does not commit before a `SERIALIZABLE` transaction `S2`, the first statement in `S2` that would observe an unwritten row from `S1` will be blocked until `S1` commits or aborts. |
There was a problem hiding this comment.
add break tags for readability
Suggested change
| - If a `READ COMMITTED` transaction `R` writes but does not commit before a `SERIALIZABLE` transaction `S`, no statement in `S` will observe or be blocked by any uncommitted writes from `R`. | |
| - If a `SERIALIZABLE` transaction `S` writes but does not commit before a `READ COMMITTED` transaction `R`, no statement in `R` will observe or be blocked by any uncommitted writes from `S`. | |
| - If a `SERIALIZABLE` transaction `S1` writes but does not commit before a `SERIALIZABLE` transaction `S2`, the first statement in `S2` that would observe an unwritten row from `S1` will be blocked until `S1` commits or aborts. | |
| - If a `READ COMMITTED` transaction `R` writes but does not commit before a `SERIALIZABLE` transaction `S`,<br>no statement in `S` will observe or be blocked by any uncommitted writes from `R`. | |
| - If a `SERIALIZABLE` transaction `S` writes but does not commit before a `READ COMMITTED` transaction `R`,<br>no statement in `R` will observe or be blocked by any uncommitted writes from `S`. | |
| - If a `SERIALIZABLE` transaction `S1` writes but does not commit before a `SERIALIZABLE` transaction `S2`,<br>the first statement in `S2` that would observe an unwritten row from `S1` will be blocked until `S1` commits or aborts. |
TFTR! I am going to merge as-is because I think this is a larger style issue. I think inserting break tags in the middle of sentences feels grammatically incorrect. Even though some of the lines in your screenshot are more readable, they also look wrong to me (particularly the shorter lines in the first bullet), as though something glitched on the webpage. We can discuss this offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-10911
Document txn behavior when mixing Serializable and Read Committed txns.
Preview: https://deploy-preview-18929--cockroachdb-docs.netlify.app/docs/v24.2/transactions.html#mixed-isolation-levels