-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rewrites for v24.3 #19098
Upgrade rewrites for v24.3 #19098
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
@dcrosta Please review the Cloud upgrade page (or nominate another reviewer) The bulk of this PR is modularizing the content into includes to build up both the self-hsoted and Cloud pages. It may be simpler to rely on the HTML previews to do the reviews. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
b054284
to
ead89d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits & suggestions, but overall lgtm!
src/current/_includes/common/upgrade/prepare-to-upgrade-cloud.md
Outdated
Show resolved
Hide resolved
- [DOC-11170] Document version skipping - [DOC-8495] Incorrect details about alpha releases - [DOC-8412] Add details about monitoring upgrade progress - [DOC-11046] Discuss major and minor version upgrades separately - [DOC-11650] v24.3 upgrade instructions - Modularize Cloud and CRDB upgrade pages to use includes - Reduce version-specific details in upgrade pages
777ead5
to
4802228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdlinville Reviewed the CC upgrade-cockroach-version. More later tonight for your review in the morning, if possible?
src/current/_includes/common/upgrade/major-version-upgrade-cloud.md
Outdated
Show resolved
Hide resolved
@mikeCRL Thank you for the reviews! Hopefully this won't take much additional work to get it merged for the release. |
@mikeCRL I think you are the one reviewer who has requested more time to review. Based on the conversation, it looks like we have reviews from Dan, David, and Alicia. I'd like to get this merged. What do you still need to do here? |
Upgrade rewrites for v24.3
Previews
Cloud: src/current/cockroachcloud/upgrade-cockroach-version.md
Self-hosted: src/current/v24.3/upgrade-cockroach-version.md
Self-hosted Kubernetes: src/current/v24.3/upgrade-cockroachdb-kubernetes.md
src/current/v24.3/cluster-virtualization-overview.md
src/current/v24.3/work-with-virtual-clusters.md