Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade docs with license key info #19125

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-11693

Copy link

Files changed:

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs ready!

Name Link
🔨 Latest commit 9e0b748
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67377f1a4407da0008636f0b
😎 Deploy Preview https://deploy-preview-19125--cockroachdb-interactivetutorials-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 9e0b748
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67377f1a1449380008cb01c9

@rmloveland rmloveland requested a review from jaiayu November 12, 2024 21:11
@rmloveland
Copy link
Contributor Author

@jaiayu i've tried to make this a self-contained part of the set of pre-upgrade steps

please take a look and let me know what you think!

the use of a common include is to facilitate backporting this update to v23.1, v23.2, v24.1, v24.2 as fast-follows from this PR

Copy link

netlify bot commented Nov 12, 2024

Netlify Preview

Name Link
🔨 Latest commit 9e0b748
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67377f1a85d7f80008ee57bd
😎 Deploy Preview https://deploy-preview-19125--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@jaiayu jaiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pending confirmation from @spilchen. LGTM

@rmloveland rmloveland requested a review from spilchen November 14, 2024 20:14
Copy link

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmloveland rmloveland requested a review from taroface November 15, 2024 11:49
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some suggestions/questions

@rmloveland rmloveland force-pushed the 20241112-DOC-11693-upgrade-page-license-key-updates branch from e3554fa to 9e0b748 Compare November 15, 2024 17:04
@rmloveland rmloveland merged commit b325e29 into main Nov 15, 2024
6 checks passed
@rmloveland rmloveland deleted the 20241112-DOC-11693-upgrade-page-license-key-updates branch November 15, 2024 17:11
rmloveland added a commit that referenced this pull request Nov 15, 2024
rmloveland added a commit that referenced this pull request Nov 15, 2024
rmloveland added a commit that referenced this pull request Nov 18, 2024
* Backport changes from #19008 (#19106)

Addresses DOC-11674

Summary of changes:

- Backport changes from #19008 to v23.1, v23.2, v24.1,
  and v24.2

* Backport changes from #19072 (#19109)

* Backport changes from #19072

Addresses DOC-11674

Summary of changes:

- Backport #19072 to v23.1, v23.2, v24.1, v24.2

* Backport changes from #19031 (#19108)

Addresses DOC-11674

Summary of changes:

- Backport #19031 to v23.1, v23.2, v24.1, v24.2

* Backport changes from #19001 (#19103)

Addresses DOC-10665, DOC-11674

Summary of changes:

- Backport changes from #19001; a few manual edits were
  required due to a few patches that didn't merge automagically

* Backport changes from #19126 (#19133)

Addresses DOC-11674, DOC-11692

* Merge origin/main into 20241029-DOC-10624-backports (#19140)

* Merge origin/main back into core relicensing backport branch (#19142)

* Backport changes from #19002 (#19138)

* Backport changes from #19002

Addresses DOC-11674

* Backport telemetry docs from #19131 (#19145)

Addresses DOC-11051

* Backport upgrade license info from #19125 (#19146)

Addresses DOC-11693

* Fix broken link on upgrade page include

---------

Co-authored-by: Rich Loveland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants