-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrade docs with license key info #19125
Update upgrade docs with license key info #19125
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
@jaiayu i've tried to make this a self-contained part of the set of pre-upgrade steps please take a look and let me know what you think! the use of a common include is to facilitate backporting this update to v23.1, v23.2, v24.1, v24.2 as fast-follows from this PR |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pending confirmation from @spilchen. LGTM
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some suggestions/questions
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
src/current/_includes/common/upgrade-cockroach-version-license-limitations.md
Outdated
Show resolved
Hide resolved
e3554fa
to
9e0b748
Compare
* Backport changes from #19008 (#19106) Addresses DOC-11674 Summary of changes: - Backport changes from #19008 to v23.1, v23.2, v24.1, and v24.2 * Backport changes from #19072 (#19109) * Backport changes from #19072 Addresses DOC-11674 Summary of changes: - Backport #19072 to v23.1, v23.2, v24.1, v24.2 * Backport changes from #19031 (#19108) Addresses DOC-11674 Summary of changes: - Backport #19031 to v23.1, v23.2, v24.1, v24.2 * Backport changes from #19001 (#19103) Addresses DOC-10665, DOC-11674 Summary of changes: - Backport changes from #19001; a few manual edits were required due to a few patches that didn't merge automagically * Backport changes from #19126 (#19133) Addresses DOC-11674, DOC-11692 * Merge origin/main into 20241029-DOC-10624-backports (#19140) * Merge origin/main back into core relicensing backport branch (#19142) * Backport changes from #19002 (#19138) * Backport changes from #19002 Addresses DOC-11674 * Backport telemetry docs from #19131 (#19145) Addresses DOC-11051 * Backport upgrade license info from #19125 (#19146) Addresses DOC-11693 * Fix broken link on upgrade page include --------- Co-authored-by: Rich Loveland <[email protected]>
Fixes DOC-11693