MOLT Fetch 1.2.1 updates #19250
MOLT Fetch 1.2.1 updates #19250
Conversation
taroface
requested review from
Jeremyyang920,
ryanluu12345,
ZhouXing19 and
noelcrl
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
LGTM for the pglogical and assume role portions (pending the discussion about if we should include an example). I'll let @noelcrl chime in on all MySQL portions.
|
Thanks @noelcrl and @ryanluu12345, PTAL! |
There was a problem hiding this comment.
Docs LGTM. I'll have @noelcrl chime in on his sections one last time. And once he gives the stamp, let's merge this :)
FYI - it also needs to pass Docs review as always. |
src/current/releases/molt.md
Outdated
|
|
||
| MOLT Fetch/Verify 1.2.1 is [available](#installation). | ||
|
|
||
| - MOLT Fetch users now can use [`--assume-role`]({% link molt/molt-fetch.md %}#global-flags) to specify a service account for assume role authentication to cloud storage. `--assume-role` must be used with `--use-implicit-auth`, or it will be ignored. |
There was a problem hiding this comment.
| - MOLT Fetch users now can use [`--assume-role`]({% link molt/molt-fetch.md %}#global-flags) to specify a service account for assume role authentication to cloud storage. `--assume-role` must be used with `--use-implicit-auth`, or it will be ignored. | |
| - MOLT Fetch users now can use [`--assume-role`]({% link molt/molt-fetch.md %}#global-flags) to specify a service account for assume role authentication to cloud storage. `--assume-role` must be used with `--use-implicit-auth`, or the service account will be ignored. |
What do you think? I had to do a quick re-read to realize that "it" was referring to assume role.
There was a problem hiding this comment.
Hmm I think we can say "the flag will be ignored" as that's simplest.
…to molt-fetch-replication-modes
DOC-11632
DOC-11724
DOC-11971
DOC-11970
DOC-11986