Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-11718 PR #134993 - ui: add Redact option to stmt diag activation modal #19254

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Dec 20, 2024

Fixes DOC-11718 DOC-8854

In statement-bundle-warning.md common include file, mentioned that users can redact data in statement bundles in v24.3.1 or later.
In v24.3 and v25.1 statement-details.md, updated Diagnostics section to include plan gist and redact options.
In v23.2, v24.1, and v24.2, statement-details.md, updated Diagnostics section to include plan gist option.

Rendered preview

…ers can redact data in statement bundles in v24.3.1 or later.

In v24.3 and v25.1 statement-details.md, updated Diagnostics section to include plan gist and redact options.

In v23.2, v24.2, and v24.2, statement-details.md, updated Diagnostics section to include plan gist option.
Copy link

Files changed:

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 067cd18
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/677bee2d061d0e000829facc

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 067cd18
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/677bee2d6d357800085ea3b8

Copy link

netlify bot commented Dec 20, 2024

Netlify Preview

Name Link
🔨 Latest commit 067cd18
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/677bee2db40fe500085efab7
😎 Deploy Preview https://deploy-preview-19254--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florence-crl florence-crl requested a review from kathancox January 3, 2025 18:45
Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo, but other than that, lgtm!

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tftr

@florence-crl florence-crl merged commit acf8fa3 into main Jan 6, 2025
6 checks passed
@florence-crl florence-crl deleted the DOC-11718 branch January 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants