sstable: fix testing bug that omitted Pebblev4 table format

In #2829 some facilities for running tests against all table formats was introduced, but it mistakenly used `< MaxTableFormat`, omitting the max table format.
cockroachdb · Aug 17, 2023 · 856ed36 · 856ed36
1 parent d77c578
commit 856ed36
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sstable/format.go b/sstable/format.go
@@ -27,7 +27,7 @@ const (
 	TableFormatPebblev4 // DELSIZED tombstones.
 	NumTableFormats
 
-	TableFormatMax = TableFormatPebblev4
+	TableFormatMax = NumTableFormats - 1
 )
 
 // TableFormatPebblev4, in addition to DELSIZED, introduces the use of

diff --git a/sstable/reader_test.go b/sstable/reader_test.go
@@ -549,7 +549,7 @@ func forEveryTableFormat[I any](
 	t *testing.T, formatTable [NumTableFormats]I, runTest func(*testing.T, TableFormat, I),
 ) {
 	t.Helper()
-	for tf := TableFormatUnspecified + 1; tf < TableFormatMax; tf++ {
+	for tf := TableFormatUnspecified + 1; tf <= TableFormatMax; tf++ {
 		t.Run(tf.String(), func(t *testing.T) {
 			runTest(t, tf, formatTable[tf])
 		})