Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: experimentally bump L0 priority in the presence of range deletes #2731

Closed
wants to merge 4 commits into from
Closed

db: experimentally bump L0 priority in the presence of range deletes #2731

wants to merge 4 commits into from

Conversation

bananabrick
Copy link
Contributor

No description provided.

@bananabrick
Copy link
Contributor Author

Not ready for a look.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bananabrick
Copy link
Contributor Author

Ran clearrange/checks=true/rangeTs=false on both this pr, and master. The precise command was roachtest run 'clearrange/checks=true/rangeTs=false' with a custom cockroach binary which included the changes in this pr. I couldn't reproduce the fsync latencies I was seeing on my initial run.

This pr:
https://grafana.testeng.crdb.io/d/ngnKs_j7x/admission-control?orgId=1&var-cluster=arjunnair-1689624245-01-n10cpu16&var-instances=All&from=1689624105666&to=1689630986084

vs

master:
https://grafana.testeng.crdb.io/d/ngnKs_j7x/admission-control?orgId=1&var-cluster=teamcity-10934590-1689572748-51-n10cpu16&var-instances=All&from=1689591729192&to=1689597957467

Graphs looks pretty similar, the differences are in the throughput, latencies, and compaction debt.

Throughput:
This pr:
Screenshot 2023-07-17 at 10 57 30 PM

vs

master:
Screenshot 2023-07-17 at 10 57 40 PM

Latencies:

Notice that this pr has pretty high pMax latencies, in general, but the p99 is much lower with this pr.

This pr:
Screenshot 2023-07-17 at 10 59 59 PM

vs

master:
Screenshot 2023-07-17 at 10 59 54 PM

There's a couple of metrics like compaction debt/lsm growth by level which look slightly worse which I will be investigating.

@bananabrick bananabrick closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants