objstorage: rename Shared to Remote in the objstorage provider API #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
shared-rename
branch
2 times, most recently
from
6adae36
to
78406f3
Compare
|
Updated to rename backing-related types and methods. |
itsbilal
approved these changes
Jul 19, 2023
`IsShared()` is split into `IsRemote()`, `IsShared()`, `IsExternal()`.
RaduBerinde
force-pushed
the
shared-rename
branch
from
78406f3
to
d05cf28
Compare
|
Thanks, fixed. Let me know if/when I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsShared()is split intoIsRemote(),IsShared(),IsExternal().I tried to update the former uses of
IsShared()appropriately - useIsRemote()in most cases but keep usingIsShared()in the disagg storage code for skip-shared iteration. These callsites can use reviewing though.I can wait to merge this when it is convenient, given the other ongoing work.