Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objstorage: rename 'shared' to 'remote' #2769

Merged

Conversation

RaduBerinde
Copy link
Member

Shared objects refer to objects that have been created by a Pebble instance and are owned by the Pebble instances in a cluster. Remote objects can be shared objects or external objects (such as those attached by online restore).

In this commit we rename uses of "shared" to "remote" in objstorage provider code that applies to all types of remote objects. We now conceptually have a remote subsystem which itself contains a shared subsystem.

Shared objects refer to objects that have been created by a Pebble
instance and are owned by the Pebble instances in a cluster. Remote
objects can be shared objects or external objects (such as those
attached by online restore).

In this commit we rename uses of "shared" to "remote" in objstorage
provider code that applies to all types of remote objects. We now
conceptually have a remote subsystem which itself contains a shared
subsystem.
@RaduBerinde RaduBerinde requested review from itsbilal and a team July 24, 2023 20:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@RaduBerinde
Copy link
Member Author

TFTR!

@RaduBerinde RaduBerinde merged commit 7ef7553 into cockroachdb:master Jul 24, 2023
9 checks passed
@RaduBerinde RaduBerinde deleted the shared-rename-provider-stuff-2 branch July 25, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants