New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/rangekey: remove ForeignSSTTransformer #2782

Merged

itsbilal merged 1 commit into cockroachdb:master from itsbilal:foreign-sst-rangekey-sort

Aug 2, 2023

Commits on Aug 1, 2023

internal/rangekey: remove ForeignSSTTransformer

Tests in cockroachdb#2698 combined with `TestIngestShared` caught that we
were not returning range keys in the order expected by other internal
iterators when reading from a foreign sstable. This change removes
the ForeignSSTTransformer as it's no longer necessary given
all range keys are emitted at the ingestion sequence number.

itsbilal committed Aug 1, 2023