sstable, sharedcache: reduce test memory usage #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce memory usage of TestGetBytes which allocates a 2GB slice. We don't actually do anything with the data so we can allocate a small slice.
Reduce the maximum sharding block size to 4MB from 10MB (we always use 1MB in production) and reduce the maximum number of shards from 64 to 32. This reduces the memory footprint of the test significantly.
|
This change is |
sumeerbhola
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2849.
sstable: reduce test memory usage
Reduce memory usage of TestGetBytes which allocates a 2GB slice. We
don't actually do anything with the data so we can allocate a small
slice.
sharedcache: reduce random test sizes
Reduce the maximum sharding block size to 4MB from 10MB (we always use
1MB in production) and reduce the maximum number of shards from 64 to
32. This reduces the memory footprint of the test significantly.