Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: add Metrics.Compact.Cancelled{Count,Bytes} #4132

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Nov 4, 2024

Add metrics for the count and bytes written by cancelled compactions.

Close #4097.

@jbowens jbowens requested a review from a team as a code owner November 4, 2024 16:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @aadityasondhi)

Add metrics for the count and bytes written by cancelled compactions.

Close cockroachdb#4097.
@jbowens
Copy link
Collaborator Author

jbowens commented Nov 4, 2024

TFTR!

@jbowens jbowens merged commit 29fdaf9 into cockroachdb:master Nov 4, 2024
23 checks passed
@jbowens jbowens deleted the cancelled-metrics branch November 4, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db: add metrics for cancelled compaction
3 participants