sstable: fix LazyFetcher lifetime #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#4123 we switched to allocating the fetcher lazily and restricting the `valueBlockReader` lifetime to that of the iterator. However, the lifetime of the `*LazyFetcher` stored in the value must outlive the iterator and it is currently lives inside `valueBlockReader`. This change fixes the bug by moving the `LazyFetcher` to `valueBlockFetcher`. Fixes cockroachdb#4131
|
This change is |
jbowens
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sumeerbhola)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4123 we switched to allocating the fetcher lazily and restricting
the
valueBlockReaderlifetime to that of the iterator. However, thelifetime of the
*LazyFetcherstored in the value must outlive theiterator and it currently lives inside
valueBlockReader.This change fixes the bug by moving the
LazyFetchertovalueBlockFetcher.Fixes #4131