internal: employ Core sequencer for pglogical & mylogical #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanluu12345
reviewed
Nov 1, 2024
| @@ -116,7 +116,8 @@ func (t *orderedAdapter) AcceptMultiBatch( | |||
| ) error { | |||
| // Peek to find the current schema. | |||
| var commonSchema ident.Schema | |||
| for table := range batch.Mutations() { | |||
| for table, mutation := range batch.Mutations() { | |||
There was a problem hiding this comment.
Why not just do for table, _ := range batch.Mutations() or leave it as it was? What's the reason for having the mutation be set to a variable that's unused?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Group: tableGroup, | ||
| // Add top-of-funnel reporting. | ||
| WrapperFunc: func(acc types.MultiAcceptor) { | ||
| acc = types.CountingAcceptor(acc, |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
|
Closing this in favor of #1065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that single stream frontend are using the pull based model.
This change is