Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column comment to get_columns method #253

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

dotan-mor
Copy link
Contributor

add comment to get_columns method to match SQLAlchemy method description and for compatiblilty with PostgreSQL

@dikshant
Copy link

dikshant commented Sep 9, 2024

@gordthompson could you help review this?

Copy link
Collaborator

@gordthompson gordthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gordthompson gordthompson merged commit b5afb7d into cockroachdb:master Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants