Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autogenerate with ON UPDATE / DELETE #258

Conversation

idumitrescu-dn
Copy link
Contributor

Fix an issue where the regular expression incorrectly parses the foreign key constraint in case an onupdate / ondelete is present.

Closes: #257

Fix an issue where the regular expression incorrectly parses the foreign
key constraint in case an `onupdate` / `ondelete` is present.

Closes: 257
Signed-off-by: Iustin Dumitrescu <[email protected]>
Copy link
Collaborator

@gordthompson gordthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@gordthompson gordthompson merged commit b9495d4 into cockroachdb:master Oct 7, 2024
11 checks passed
@idumitrescu-dn idumitrescu-dn deleted the idumitrescu/fix-on-update-delete branch October 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict for ON UPDATE / ON DELETE
2 participants