Skip to content

Commit

Permalink
Don't hack CULL_MESHOPT. (#55)
Browse files Browse the repository at this point in the history
  • Loading branch information
dumganhar authored Jan 22, 2024
1 parent 65ca9e6 commit 4abce10
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions modules/build-engine/src/engine-js/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,7 @@ export async function buildJsEngine(options: Required<buildEngine.Options>): Pro

const flags = options.flags ?? {};

// meshopt is only used in 3d module, so cull it if 3d module is disabled.
if (flags.CULL_MESHOPT === undefined) {
flags.CULL_MESHOPT = !features.includes('3d');
}
flags.CULL_MESHOPT = !features.includes('meshopt');

const intrinsicFlags = statsQuery.getIntrinsicFlagsOfFeatures(features);
let buildTimeConstants = statsQuery.constantManager.genBuildTimeConstants({
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cocos/ccbuild",
"version": "2.2.2",
"version": "2.2.3",
"description": "The next generation of build tool for Cocos engine.",
"main": "./lib/index.js",
"types": "./lib/index.d.ts",
Expand Down

0 comments on commit 4abce10

Please sign in to comment.