Fix spine.wasm could not run in safari with iOS which version is lower than 15. #15515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
commented
Jun 21, 2023
| set(EMS_LINK_FLAGS "-O3 -s WASM=0 -s INITIAL_MEMORY=33554432 -s ALLOW_MEMORY_GROWTH=1 -s DYNAMIC_EXECUTION=0 -s ERROR_ON_UNDEFINED_SYMBOLS=0 \ | ||
| -flto --no-entry --bind -s USE_ES6_IMPORT_META=0 -s EXPORT_ES6=1 -s MODULARIZE=1 -s EXPORT_NAME='spineWasm' \ | ||
| -s ENVIRONMENT=web -s FILESYSTEM=0 -s NO_EXIT_RUNTIME=1 -s LLD_REPORT_UNDEFINED --js-library ../library_spine.js") | ||
| -s ENVIRONMENT=web -s FILESYSTEM=0 -s NO_EXIT_RUNTIME=1 -s LLD_REPORT_UNDEFINED \ | ||
| -s MIN_SAFARI_VERSION=110000 \ |
There was a problem hiding this comment.
Add -s MIN_SAFARI_VERSION=110000
dumganhar
force-pushed
the
fix/spine-wasm-lower-than-ios15
branch
from
d280a22
to
386c5a2
Compare
PPpro
approved these changes
Jun 21, 2023
Interface Check ReportThis pull request does not change any public interfaces ! |
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details
|
minggo
approved these changes
Jun 25, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cocos/cocos-engine-external#370
https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3126---111722
Inline with the recent changes to llvm and binaryen, emscripten will now, by default, enable the sign-extension and mutable-globals WebAssembly proposals. In order to do so the default minimum safari version (MIN_SAFARI_VERSION) was updated from 12.0 to 14.1, and support for the old EdgeHTML engine (MIN_EDGE_VERSION) was removed by default. If you want to continue to support these older engines you can use these settings (-sMIN_SAFARI_VERSION=120000 and/or -sMIN_EDGE_VERSION=44) to revert to the previous defaults, which will result in the new proposals being disabled. Note that in order to avoid support for the sign-extension emscripten uses a binaryen pass, so targeting older browsers requires the running of wasm-opt and is therefore incompatible with ERROR_ON_WASM_CHANGES_AFTER_LINK (i.e. fast linking).
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: