Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back WASM_FALLBACK constant #15758

Merged
merged 1 commit into from
Jul 18, 2023
Merged

add back WASM_FALLBACK constant #15758

merged 1 commit into from
Jul 18, 2023

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Jul 18, 2023

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@PPpro PPpro requested a review from minggo July 18, 2023 07:02
@minggo
Copy link
Contributor

minggo commented Jul 18, 2023

Is this constant used?

@PPpro
Copy link
Contributor Author

PPpro commented Jul 18, 2023

no for now, but it's a feature for engine build tool, we sill need keep this constant @minggo
So that when we need it, we can use it directly

@minggo minggo merged commit c10a724 into cocos:v3.8.0 Jul 18, 2023
11 checks passed
@PPpro PPpro deleted the v3.8.0 branch July 18, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants