Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] fix type for AOT engine #15526

Merged
merged 7 commits into from
Jun 27, 2023
Merged

[AOT] fix type for AOT engine #15526

merged 7 commits into from
Jun 27, 2023

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Jun 25, 2023

Re: https://github.com/cocos/3d-tasks/issues/16803

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@PPpro PPpro requested a review from minggo June 25, 2023 09:21
@PPpro PPpro changed the title fix: type for AOT engine AOT: fix type for AOT engine Jun 25, 2023
@github-actions
Copy link

github-actions bot commented Jun 25, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -47956,9 +47956,9 @@
              * @zh
              * 获取或设置角色控制器的中心点在局部坐标系中的位置。
              */
             get center(): Readonly<math.Vec3>;
-            set center(value: math.Vec3);
+            set center(value: Readonly<math.Vec3>);
             /**
              * @en
              * Gets the type of this character controller.
              * @zh
@@ -47985,9 +47985,9 @@
              * Sets world position of center.
              * @zh
              * 设置中心的世界坐标。
              */
-            set centerWorldPosition(value: math.Vec3);
+            set centerWorldPosition(value: Readonly<math.Vec3>);
             /**
              * @en
              * Gets the velocity.
              * @zh
@@ -61908,39 +61908,39 @@
         }
         export type _cocos_serialization_deserialize_dynamic__ClassFinder = deserialize.ClassFinder;
         export type _cocos_serialization_deserialize_dynamic__ReportMissingClass = deserialize.ReportMissingClass;
         export type _cocos_serialization_deserialize_dynamic__TypedArrayViewConstructorName = "Uint8Array" | "Int8Array" | "Uint16Array" | "Int16Array" | "Uint32Array" | "Int32Array" | "Float32Array" | "Float64Array";
-        export type _cocos_serialization_deserialize_dynamic__SerializedTypedArray = {
+        export interface _cocos_serialization_deserialize_dynamic__SerializedTypedArray {
             __id__: never;
             __uuid__: never;
             __type__: "TypedArray";
             array: number[];
             ctor: _cocos_serialization_deserialize_dynamic__TypedArrayViewConstructorName;
-        };
-        export type _cocos_serialization_deserialize_dynamic__SerializedTypedArrayRef = {
+        }
+        export interface _cocos_serialization_deserialize_dynamic__SerializedTypedArrayRef {
             __id__: never;
             __uuid__: never;
             __type__: "TypedArrayRef";
             ctor: _cocos_serialization_deserialize_dynamic__TypedArrayViewConstructorName;
             offset: number;
             length: number;
-        };
+        }
         export type _cocos_serialization_deserialize_dynamic__NotA<T, ReservedNames> = T extends ReservedNames ? never : T;
         export type _cocos_serialization_deserialize_dynamic__NotB<T, ReservedNames> = ReservedNames extends T ? never : T;
         export type _cocos_serialization_deserialize_dynamic__FooName<T, ReservedNames> = _cocos_serialization_deserialize_dynamic__NotA<T, ReservedNames> & _cocos_serialization_deserialize_dynamic__NotB<T, ReservedNames>;
         export type _cocos_serialization_deserialize_dynamic__NotKnownTypeTag = _cocos_serialization_deserialize_dynamic__FooName<string, "TypedArray" | "TypedArrayRef">;
         export type _cocos_serialization_deserialize_dynamic__NotTypeTag = _cocos_serialization_deserialize_dynamic__FooName<string, "__type__">;
-        export type _cocos_serialization_deserialize_dynamic__SerializedObjectReference = {
+        export interface _cocos_serialization_deserialize_dynamic__SerializedObjectReference {
             __type__: never;
             __uuid__: never;
             __id__: number;
-        };
-        export type _cocos_serialization_deserialize_dynamic__SerializedUUIDReference = {
+        }
+        export interface _cocos_serialization_deserialize_dynamic__SerializedUUIDReference {
             __type__: never;
             __id__: never;
             __uuid__: string;
             __expectedType__: string;
-        };
+        }
         export type _cocos_serialization_deserialize_dynamic__SerializedFieldObjectValue = _cocos_serialization_deserialize_dynamic__SerializedObjectReference | _cocos_serialization_deserialize_dynamic__SerializedUUIDReference | unknown;
         export type _cocos_serialization_deserialize_dynamic__SerializedFieldValue = string | number | boolean | null | _cocos_serialization_deserialize_dynamic__SerializedFieldObjectValue;
         export type _cocos_serialization_deserialize_dynamic__SerializedGeneralTypedObject = {
             __id__: never;

@PPpro PPpro force-pushed the 381-aot branch 2 times, most recently from 033fa4b to c43543f Compare June 25, 2023 10:27
@PPpro PPpro changed the title AOT: fix type for AOT engine [AOT] fix type for AOT engine Jun 25, 2023
@minggo minggo requested a review from shrinktofit June 27, 2023 05:45
@minggo minggo merged commit 491c0cf into cocos:v3.8.1 Jun 27, 2023
10 checks passed
@PPpro PPpro deleted the 381-aot branch June 27, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants