Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mac editbox show bug when resize #15533

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix mac editbox show bug when resize #15533

merged 1 commit into from
Jun 26, 2023

Conversation

mmyduckx
Copy link
Contributor

Re: #https://github.com/cocos/3d-tasks/issues/16583

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

minggo
minggo reviewed Jun 26, 2023
View reviewed changes
native/cocos/ui/edit-box/EditBox-mac.mm
@@ -149,6 +150,9 @@ - (NSAttributedString *)attributedStringForObjectValue:(id)anObject withDefaultA
Implementation of global helper functions.
************************************************************************/
namespace {

static cc::events::Resize::Listener resizeListener;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where to initialize it?

Copy link
Contributor Author

@mmyduckx mmyduckx Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Events internal implementation by @PatriceJiang .
Similar usage in editBox-ios.mm

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo merged commit 4958306 into cocos:v3.8.1 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatriceJiang PatriceJiang PatriceJiang approved these changes

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmyduckx @minggo @PatriceJiang