Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tone mapping #15558

Merged
merged 20 commits into from
Jul 25, 2023
Merged

add tone mapping #15558

merged 20 commits into from
Jul 25, 2023

Conversation

xubing0906
Copy link
Contributor

@xubing0906 xubing0906 commented Jun 27, 2023

Re: https://github.com/cocos/3d-tasks/issues/14336

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -12622,8 +12622,21 @@
                 updateBoundingBox(): void;
                 hasFrameBuffer(framebuffer: gfx.Framebuffer): boolean;
                 isRGBE(): boolean;
             }
+            export const ToneMappingType: {
+                DEFAULT: number;
+                LINEAR: number;
+            };
+            export class ToneMapping {
+                protected _toneMappingType: number;
+                protected _activated: boolean;
+                set toneMappingType(val: number);
+                get toneMappingType(): number;
+                initialize(toneMappingInfo: ToneMappingInfo): void;
+                activate(): void;
+                protected _updatePipeline(): void;
+            }
         }
         export enum RenderQueue {
             OPAQUE = 0,
             TRANSPARENT = 1,
@@ -23260,8 +23273,9 @@
         shadows: renderer.scene.Shadows;
         csmLayers: __private._cocos_rendering_shadow_csm_layers__CSMLayers;
         octree: renderer.scene.Octree;
         skin: renderer.scene.Skin;
+        toneMapping: renderer.scene.ToneMapping;
         lightProbes: any;
         /**
          * @en The list for valid punctual Lights, only available after the scene culling of the current frame.
          * @zh 场景中精确的有效光源,仅在当前帧的场景剔除完成后有效。
@@ -26184,8 +26198,19 @@
          * @param resource The skin configuration object in the render scene
          */
         activate(resource: renderer.scene.Skin): void;
     }
+    export class ToneMappingInfo {
+        /**
+         * @zh 色调映射类型
+         * @en Tone mapping type
+         */
+        set toneMappingType(val: number);
+        get toneMappingType(): number;
+        protected _toneMappingType: number;
+        protected _resource: renderer.scene.ToneMapping | null;
+        activate(resource: renderer.scene.ToneMapping): void;
+    }
     export interface ILightProbeNode {
         node: Node;
         probes: math.Vec3[] | null;
     }
@@ -26315,8 +26340,13 @@
          * @zh 光照探针相关配置
          */
         lightProbeInfo: LightProbeInfo;
         /**
+         * @en Tone mapping related configuration
+         * @zh 色调映射相关配置
+         */
+        toneMapping: ToneMappingInfo;
+        /**
          * @en bake with stationary main light
          * @zh 主光源是否以静止状态烘培
          */
         bakedWithStationaryMainLight: boolean;

@xubing0906
Copy link
Contributor Author

@cocos-robot run test cases

@xubing0906 xubing0906 closed this Jun 29, 2023
@xubing0906 xubing0906 reopened this Jun 29, 2023
# Conflicts:
#	editor/i18n/en/localization.js
#	editor/inspector/contributions/node.js
@xubing0906
Copy link
Contributor Author

image

@github-actions
Copy link

@xubing0906, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS PASS

@@ -0,0 +1,37 @@
import { Enum, cclegacy } from '../../core';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-settings

@github-actions
Copy link

@xubing0906, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL particle-rotation,particle-size
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@github-actions
Copy link

@xubing0906, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL particle-rotation,particle-size
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@jk20012001 jk20012001 merged commit d97d3c6 into cocos:v3.8.1 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants