fix: wrong asm.js mem url on minigame platforms #15559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
|
Please do more test. |
PPpro
changed the title
PPpro
commented
Jun 28, 2023
Comment on lines
-34
to
-47
| // fsUtils is defined in engine-adapter | ||
| const fsUtils = globalThis.fsUtils; | ||
| if (OPPO) { | ||
| getBinaryUrlOnOPPO(binaryUrl).then((url) => { | ||
| fsUtils.readArrayBuffer(url, (err, arrayBuffer) => { | ||
| if (err) { | ||
| reject(err); | ||
| return; | ||
| } | ||
| resolve(arrayBuffer); | ||
| }); | ||
| }).catch((e) => {}); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I revert this bug fix because we cannot rely on the file read interface on production enviroment, the engine plugin is not in the package.
I fix this url issue in the editor build plugin instead https://github.com/cocos/creator-runtime-extensions/pull/443/commits/cfb00bf2996d7ab44ce3a43a3fbd80cc99a450e2
minggo
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos/3d-tasks/issues/17088
Changelog
dep PR
https://github.com/cocos/creator-runtime-extensions/pull/443
Continuous Integration
This pull request:
Compatibility Check
This pull request: