Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine post process #15566

Merged
merged 1 commit into from
Jun 29, 2023
Merged

refine post process #15566

merged 1 commit into from
Jun 29, 2023

Conversation

2youyou2
Copy link
Contributor

Re: #

Changelog

  • add tool tips
  • fix blit screen
  • change fsr sharpness range to 0 => 1

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@2youyou2 2youyou2 requested a review from jk20012001 June 28, 2023 07:47
@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -35304,10 +35304,14 @@
             updateActiveMateirals(): void;
             onLoad(): void;
         }
         export class TAA extends PostProcessSetting {
-            sampleScale: number;
-            feedback: number;
+            _sampleScale: number;
+            get sampleScale(): number;
+            set sampleScale(v: number);
+            _feedback: number;
+            get feedback(): number;
+            set feedback(v: number);
         }
         export class ColorGrading extends PostProcessSetting {
             protected _contribute: number;
             protected _colorGradingMap: Texture2D | null;

@jk20012001 jk20012001 merged commit 66dca24 into cocos:v3.8.0 Jun 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants