Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where the pause and resume function of the mini game platform is not working properly when switching between the front and back end. #15811

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

bofeng-song
Copy link
Contributor

Re: #https://github.com/cocos/3d-tasks/issues/15358

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested review from PPpro and minggo July 24, 2023 09:07
Comment on lines 61 to 62
game.off(Game.EVENT_PAUSE, this._onInterruptedBegin, this);
game.off(Game.EVENT_RESUME, this._onInterruptedEnd, this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

game module is in the framework layer, pal should not rely on it
please use systemInfo.on('show') systemInfo.on('hide') instead

pal/audio/minigame/player-minigame.ts Outdated Show resolved Hide resolved
@minggo minggo merged commit 4a2f290 into cocos:v3.8.1 Aug 1, 2023
@bofeng-song bofeng-song changed the title Fix audio can not be paused & resume on mini game platform Fix the issue where the pause and resume function of the mini game platform is not working properly when switching between the front and back end. Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants