Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoseGraph: support editor decorators on node inputs #15819

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

shrinktofit
Copy link
Contributor

@shrinktofit shrinktofit commented Jul 26, 2023

Changelog

  • Support editor series decorators on pose graph node properties, for example @visible, @range etc.

This replies to https://github.com/cocos/3d-tasks/issues/16600 .


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Comment on lines +99 to +100
delete attrs.type;
delete attrs.ctor;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An input's type is not specified by cc-class system. It's specified by @poseGraphType

@SantyWang SantyWang merged commit 5eddce9 into cocos:v3.8.1 Aug 1, 2023
10 checks passed
@shrinktofit shrinktofit deleted the PoseGraphDecorator branch August 3, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants