Optimize pack-manager for style&lint #15872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinktofit
commented
Aug 4, 2023
Comment on lines
+35
to
+40
| export type Unpacker = ( | ||
| packUuid: string[], | ||
| data: any, | ||
| options: Record<string, any>, | ||
| onComplete: ((err: Error | null, data?: any) => void), | ||
| ) => void; |
There was a problem hiding this comment.
Lint problem: too long line
shrinktofit
commented
Aug 4, 2023
|
|
||
| interface IUnpackRequest { | ||
| onComplete: ((err: Error | null, data?: any | null) => void); | ||
| onComplete: ((err: Error | null, data?: any) => void); |
There was a problem hiding this comment.
Lint problem: any | null is equivalent to any.
shrinktofit
commented
Aug 4, 2023
| @@ -73,12 +78,17 @@ export class PackManager { | |||
| * }); | |||
| * | |||
| */ | |||
| public unpackJson (pack: string[], json: any, options: Record<string, any>, onComplete: ((err: Error | null, data?: Record<string, any> | null) => void)): void { | |||
| let out = js.createMap(true); | |||
| public unpackJson ( | |||
There was a problem hiding this comment.
Lint problem: too long line
shrinktofit
commented
Aug 4, 2023
| options: Record<string, any>, | ||
| onComplete: ((err: Error | null, data?: Record<string, any> | null) => void), | ||
| ): void { | ||
| const out: Record<string, any> = js.createMap(true); |
There was a problem hiding this comment.
Problem: untyped thing.
shrinktofit
commented
Aug 4, 2023
| let err: Error | null = null; | ||
|
|
||
| if (Array.isArray(json)) { | ||
| json = unpackJSONs(json as any); | ||
| json = unpackJSONs(json as Parameters<typeof unpackJSONs>[0]); |
There was a problem hiding this comment.
Problem: type cast
shrinktofit
commented
Aug 4, 2023
| @@ -107,7 +117,8 @@ export class PackManager { | |||
| } | |||
| } else { | |||
| err = new Error('unmatched type pack!'); | |||
| out = null; | |||
| onComplete(err, null); | |||
There was a problem hiding this comment.
Problem: if don't do this, the out should be null | Record<...> which then causes many assertions in above.
shrinktofit
commented
Aug 4, 2023
| @@ -170,7 +181,13 @@ export class PackManager { | |||
| * }); | |||
| * | |||
| */ | |||
| public unpack (pack: string[], data: any, type: string, options: Record<string, any>, onComplete: ((err: Error | null, data?: any | null) => void)): void { | |||
| public unpack ( | |||
There was a problem hiding this comment.
Lint problem: too long line
shrinktofit
commented
Aug 4, 2023
| @@ -200,7 +217,7 @@ export class PackManager { | |||
| * packManager.load(requestItem, null, (err, data) => console.log(err)); | |||
| * | |||
| */ | |||
| public load (item: RequestItem, options: Record<string, any> | null, onComplete: ((err: Error | null, data?: any | null) => void)): void { | |||
| public load (item: RequestItem, options: Record<string, any> | null, onComplete: ((err: Error | null, data?: any) => void)): void { | |||
There was a problem hiding this comment.
Lint problem: any | null is equivalent to any.
shrinktofit
commented
Aug 4, 2023
| @@ -215,35 +232,39 @@ export class PackManager { | |||
| const packs = item.info.packs; | |||
|
|
|||
| // find a loading package | |||
| let pack = packs.find((val): boolean => this._loading.has(val.uuid)); | |||
| const loadingPack = packs.find((val): boolean => this._loading.has(val.uuid)); | |||
There was a problem hiding this comment.
To avoid below from pack! assertion.
shrinktofit
commented
Aug 4, 2023
| for (let i = 0, l = callbacks!.length; i < l; i++) { | ||
| const cb = callbacks![i]; | ||
| const callbacks = this._loading.remove(pack.uuid); | ||
| assertIsTrue(callbacks); |
There was a problem hiding this comment.
Prefer explicit assertion.
SantyWang
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: