Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.8.1 pipeline #15906

Merged
merged 21 commits into from
Aug 10, 2023
Merged

V3.8.1 pipeline #15906

merged 21 commits into from
Aug 10, 2023

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Aug 9, 2023

update custom pipeline implementation
fixed auto-test compile error

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -35128,11 +35128,12 @@
             FLOAT_TYPE = 1,
             INT_TYPE = 2
         }
         export class LightInfo {
-            constructor(light?: renderer.scene.Light | null, level?: number);
+            constructor(light?: renderer.scene.Light | null, level?: number, culledByLight?: boolean);
             light: renderer.scene.Light | null;
             level: number;
+            culledByLight: boolean;
         }
         export enum DescriptorTypeOrder {
             UNIFORM_BUFFER = 0,
             DYNAMIC_UNIFORM_BUFFER = 1,
@@ -35465,8 +35466,13 @@
              */
             setSampler(name: string, sampler: gfx.Sampler): void;
             setBuiltinCameraConstants(camera: renderer.scene.Camera): void;
             setBuiltinShadowMapConstants(light: renderer.scene.DirectionalLight): void;
+            setBuiltinDirectionalLightConstants(light: renderer.scene.DirectionalLight, camera: renderer.scene.Camera): void;
+            setBuiltinSphereLightConstants(light: renderer.scene.SphereLight, camera: renderer.scene.Camera): void;
+            setBuiltinSpotLightConstants(light: renderer.scene.SpotLight, camera: renderer.scene.Camera): void;
+            setBuiltinPointLightConstants(light: renderer.scene.PointLight, camera: renderer.scene.Camera): void;
+            setBuiltinRangedDirectionalLightConstants(light: renderer.scene.RangedDirectionalLight, camera: renderer.scene.Camera): void;
             setBuiltinDirectionalLightViewConstants(light: renderer.scene.DirectionalLight, level?: number): void;
             setBuiltinSpotLightViewConstants(light: renderer.scene.SpotLight): void;
         }
         /**
@@ -35486,9 +35492,9 @@
              * @param light @en Lighting information of the scene @zh 场景光照信息
              * @param sceneFlags @en Rendering flags of the scene @zh 场景渲染标志位
              */
             addSceneOfCamera(camera: renderer.scene.Camera, light: LightInfo, sceneFlags?: SceneFlags): void;
-            addScene(camera: renderer.scene.Camera, sceneFlags: SceneFlags): void;
+            addScene(camera: renderer.scene.Camera, sceneFlags: SceneFlags, light?: renderer.scene.Light | null): void;
             addSceneCulledByDirectionalLight(camera: renderer.scene.Camera, sceneFlags: SceneFlags, light: renderer.scene.DirectionalLight, level: number): void;
             addSceneCulledBySpotLight(camera: renderer.scene.Camera, sceneFlags: SceneFlags, light: renderer.scene.SpotLight): void;
             /**
              * @en Render a full-screen quad.

@star-e star-e marked this pull request as ready for review August 10, 2023 06:36
@star-e
Copy link
Contributor Author

star-e commented Aug 10, 2023

@cocos-robot run test cases

@star-e star-e requested review from minggo and removed request for minggo August 10, 2023 06:39
@star-e star-e marked this pull request as draft August 10, 2023 06:40
@star-e star-e marked this pull request as ready for review August 10, 2023 06:58
@@ -160,6 +148,21 @@ struct BarrierNode {
std::vector<Barrier> rearBarriers;
};

struct SliceNode {
bool full{false};
std::vector<uint32_t> mips;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use ccstd::vector<>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

@star-e star-e merged commit ad6e3dc into cocos:v3.8.1 Aug 10, 2023
23 checks passed
@github-actions
Copy link

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL compressWithGray compressWithGray
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants