Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gles3 gl target #15914

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix gles3 gl target #15914

merged 2 commits into from
Aug 14, 2023

Conversation

bluesky013
Copy link
Contributor

@bluesky013 bluesky013 commented Aug 10, 2023

Re: #

gl texture target should saved by texture view.

For example, a texture created with 6 layer. Each layer can be used as a 2d target or cubemap face target.

TextureType in TextureInfo used to create a default texture view of an HW image and also decide ImageType(1D, 2D, 3D).
TextureType in TextureViewInfo used to create view type of source image.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@bluesky013
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@bluesky013, Please check the result of run test cases:

Task Details

@github-actions
Copy link

@bluesky013, Please check the result of run test cases:

Task Details

@bluesky013 bluesky013 requested review from star-e and minggo and removed request for star-e August 10, 2023 05:54
@minggo minggo merged commit 2b266ac into cocos:v3.8.1 Aug 14, 2023
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants