Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove string literal in nodiscard #15918

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ void fillRenderPassInfo(const AttachmentMap &colorMap,
}
};

[[nodiscard("concat")]] ccstd::pmr::string concatResName(
[[nodiscard]] ccstd::pmr::string concatResName(
std::string_view name0,
std::string_view name1,
boost::container::pmr::memory_resource *scratch) {
Expand Down Expand Up @@ -857,7 +857,7 @@ void extractNames(const ccstd::pmr::string &resName,
}
}

[[nodiscard("subresName")]] ccstd::pmr::string getSubresName(const ccstd::pmr::string &resName,
[[nodiscard]] ccstd::pmr::string getSubresName(const ccstd::pmr::string &resName,
uint32_t planeID, const ResourceGraph& resg,
boost::container::pmr::memory_resource* scratch) {
const auto& desc = get(ResourceGraph::DescTag{}, resg, vertex(resName, resg));
Expand Down
Loading