fix disabled shadow inconsistency #17337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
star-e
commented
Jul 9, 2024
Comment on lines
874
to
882
| { // find or create csm info | ||
| const BuiltinCascadedShadowMapKey key{&camera, mainLight}; | ||
| auto iter = ppl.builtinCSMs.find(key); | ||
| if (iter != ppl.builtinCSMs.end()) { | ||
| result = &iter->second; | ||
| } else { | ||
| result = addBuiltinCSMInfo(ppl, pplSceneData, camera, mainLight, key, csmLayers); | ||
| } | ||
| } |
There was a problem hiding this comment.
Always insert csm info.
minggo
reviewed
Jul 9, 2024
minggo
reviewed
Jul 9, 2024
| // shadow not enabled | ||
| if (!shadows.isEnabled()) { | ||
| return nullptr; | ||
| } |
There was a problem hiding this comment.
Can also check it as soon as possible.
There was a problem hiding this comment.
Check shadow not enabled earlier caused the mismatch. When doing the rendering, csm info is always needed.
minggo
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing csm info caused by mismatching set/get pair.
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: