Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.8.4 reduce code #17428

Merged
merged 7 commits into from
Jul 29, 2024
Merged

V3.8.4 reduce code #17428

merged 7 commits into from
Jul 29, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Jul 26, 2024

Simplify pipeline settings, to reduce code size.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request focuses on reducing code complexity and improving maintainability in the rendering pipeline and related components.

  • cocos/rendering/custom/render-graph.ts: Added isDepthStencil parameter to RenderSwapchain class and methods for better swapchain configuration.
  • cocos/rendering/custom/web-pipeline.ts: Modified RenderSwapchain instantiation in WebPipeline to include a new boolean parameter for enhanced depth-stencil handling.
  • editor/assets/default_renderpipeline/builtin-pipeline-settings.ts: Replaced makePipelineSettings function with direct PipelineSettings instantiation and updated DoF properties to be hidden in the editor UI.
  • editor/assets/default_renderpipeline/builtin-pipeline-types.ts: Refactored to use class-based definitions for rendering pipeline settings, improving readability and maintainability.
  • native/cocos/renderer/pipeline/custom/FrameGraphDispatcher.cpp: Added CC_EXPECTS checks to ensure correct usage of depth-stencil properties in the rendering pipeline.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@star-e star-e requested a review from dumganhar July 29, 2024 03:40
@dumganhar dumganhar merged commit 6723388 into cocos:v3.8.4 Jul 29, 2024
10 checks passed
@star-e star-e deleted the v3.8.4-reduce-code branch July 29, 2024 06:28
star-e added a commit to star-e/cocos-engine that referenced this pull request Jul 31, 2024
* V3.8.4 reduce code (cocos#17428)

Has bug in editor.
@star-e star-e mentioned this pull request Jul 31, 2024
6 tasks
star-e added a commit that referenced this pull request Jul 31, 2024
* V3.8.4 reduce code (#17428)

Has bug in editor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants