-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3.8.4 reduce code #17428
V3.8.4 reduce code #17428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check ReportThis pull request does not change any public interfaces ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
* V3.8.4 reduce code (cocos#17428) Has bug in editor.
Simplify pipeline settings, to reduce code size.
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
This pull request focuses on reducing code complexity and improving maintainability in the rendering pipeline and related components.
cocos/rendering/custom/render-graph.ts
: AddedisDepthStencil
parameter toRenderSwapchain
class and methods for better swapchain configuration.cocos/rendering/custom/web-pipeline.ts
: ModifiedRenderSwapchain
instantiation inWebPipeline
to include a new boolean parameter for enhanced depth-stencil handling.editor/assets/default_renderpipeline/builtin-pipeline-settings.ts
: ReplacedmakePipelineSettings
function with directPipelineSettings
instantiation and updated DoF properties to be hidden in the editor UI.editor/assets/default_renderpipeline/builtin-pipeline-types.ts
: Refactored to use class-based definitions for rendering pipeline settings, improving readability and maintainability.native/cocos/renderer/pipeline/custom/FrameGraphDispatcher.cpp
: AddedCC_EXPECTS
checks to ensure correct usage of depth-stencil properties in the rendering pipeline.