-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda capture type issues for VS 2017 and use right operator for createJSONObject(std::u16string &&jsonStr) #17472
Conversation
@cocos-robot run test cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check ReportThis pull request does not change any public interfaces ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Re: #17012
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
This pull request addresses lambda capture type issues for VS 2017 and optimizes JSON object creation from UTF-16 strings.
native/cocos/bindings/manual/jsb_cocos_manual.cpp
: Refactoredjs_readFile
into modular functions, introducedJSB_READ_FILE
macro, and improved error handling and logging.native/cocos/bindings/jswrapper/v8/Object.cpp
: UpdatedcreateJSONObject
to usestd::u16string &&
andstd::move
for efficient memory management.native/cocos/bindings/jswrapper/v8/Object.h
: ModifiedcreateJSONObject
to accept an rvalue reference, enhancing performance by avoiding unnecessary string copies.native/cocos/bindings/jswrapper/v8/Utils.h
: AdjustedExternalStringResource
constructor to use rvalue references, improving performance by reducing allocations and copies.