Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda capture type issues for VS 2017 and use right operator for createJSONObject(std::u16string &&jsonStr) #17472

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Aug 1, 2024

Re: #17012

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request addresses lambda capture type issues for VS 2017 and optimizes JSON object creation from UTF-16 strings.

  • native/cocos/bindings/manual/jsb_cocos_manual.cpp: Refactored js_readFile into modular functions, introduced JSB_READ_FILE macro, and improved error handling and logging.
  • native/cocos/bindings/jswrapper/v8/Object.cpp: Updated createJSONObject to use std::u16string && and std::move for efficient memory management.
  • native/cocos/bindings/jswrapper/v8/Object.h: Modified createJSONObject to accept an rvalue reference, enhancing performance by avoiding unnecessary string copies.
  • native/cocos/bindings/jswrapper/v8/Utils.h: Adjusted ExternalStringResource constructor to use rvalue references, improving performance by reducing allocations and copies.

@dumganhar dumganhar requested a review from minggo August 1, 2024 04:49
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

github-actions bot commented Aug 1, 2024

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@dumganhar dumganhar merged commit 046545c into cocos:v3.8.4 Aug 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants