fix #17484: 修复tsx文件对象层自定义属性读取错误 #17486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -19753,9 +19753,9 @@
export class frustum extends Frustum {
constructor();
}
}
- export const VERSION = "3.8.4";
+ export const VERSION = "3.8.5";
/**
* @en
* The main namespace of Cocos engine, all engine core classes, functions, properties and constants are defined in this namespace.
* @zh
@@ -63959,15 +63959,15 @@
* @en The event type indicates mouse leaves the window or canvas. Only Windows, macOS or web PC can
* trigger this event.
* @zh 当鼠标离开窗口或者 canvas 时发出该消息。只有 Windows、macOS 或者 PC web 会触发该事件。
*/
- MOUSE_LEAVE = "mouse-leave-window",
+ MOUSE_LEAVE = "mouse-leave",
/**
* @en The event type indicates mouse enters the window or canvas. Only Windows, macOS or web PC can
* trigger this event.
* @zh 当鼠标进入窗口或者 canvas 时发出该消息。只有 Windows、macOS 或者 PC web 会触发该事件。
*/
- MOUSE_ENTER = "mouse-enter-window",
+ MOUSE_ENTER = "mouse-enter",
/**
* @en
* The event type for mouse wheel events
*
@@ -69631,8 +69631,9 @@
*/
TEXT = 5
}
export interface _cocos_tiledmap_tiled_types__TMXObject {
+ properties: _cocos_tiledmap_tiled_types__PropertiesInfo;
id: number | string;
name: string;
width: number;
height: number;
|
qiuguohua
reviewed
Aug 16, 2024
cocos/tiledmap/tmx-xml-parser.ts
Outdated
| @@ -89,7 +89,7 @@ function strToColor (value: string): Color { | |||
|
|
|||
| function getPropertyList (node: Element, map?: PropertiesInfo): PropertiesInfo { | |||
| const res: any[] = []; | |||
| const properties = node.getElementsByTagName('properties'); | |||
| const properties = node.querySelectorAll(':scope > properties'); | |||
|
@Jerry457 There is also a ci error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This pull request addresses issue #17484 by fixing the error in reading custom properties of object layers from TSX files.
propertiesfield toTMXObjectinterface incocos/tiledmap/tiled-types.ts.getPropertyListfunction incocos/tiledmap/tmx-xml-parser.tsto usequerySelectorAllfor better property selection.parseObjectGroupmethod incocos/tiledmap/tmx-xml-parser.tsto correctly assign properties to object layers.