-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed 3d-tasks/18423: Rendering is not correct on VK backend. #17526
Conversation
Async tasks must be executed after present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check ReportThis pull request does not change any public interfaces ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@cocos-robot run test cases |
@dumganhar, Please check the result of
Task Details |
@dumganhar, Please check the result of
Task Details |
Async tasks must be executed after present.
Re: https://github.com/cocos/3d-tasks/issues/18423
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
The changes in this pull request address rendering issues on the Vulkan backend by ensuring that asynchronous tasks are executed after the present operation.
cc::Root::AfterPresent
event in/native/cocos/core/Root.h
.AfterPresent
event after_device->present();
in/native/cocos/core/Root.cpp
.AfterPresent
event listener injs_root_registerListeners
function in/native/cocos/bindings/manual/jsb_scene_manual.cpp
.