Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 3d-tasks/18423: Rendering is not correct on VK backend. #17526

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Aug 12, 2024

Async tasks must be executed after present.

Re: https://github.com/cocos/3d-tasks/issues/18423

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

The changes in this pull request address rendering issues on the Vulkan backend by ensuring that asynchronous tasks are executed after the present operation.

  • Added cc::Root::AfterPresent event in /native/cocos/core/Root.h.
  • Emitted AfterPresent event after _device->present(); in /native/cocos/core/Root.cpp.
  • Added AfterPresent event listener in js_root_registerListeners function in /native/cocos/bindings/manual/jsb_scene_manual.cpp.

Async tasks must be executed after present.
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

@minggo minggo merged commit 2b032a2 into cocos:v3.8.4 Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants