Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constrain UI phase ID to PassLayout/'default' #17542

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Aug 15, 2024

https://github.com/cocos/3d-tasks/issues/18445

Previously all materials passes will be rendered, if their ${PassLayoutName} equals the one in render graph node.
Now they are constrained to ${PassLayoutName}/'default'.
As a result, 'default'/'additive-light' objects will not be rendered in UI. This behavior is the same as in legacy-pipeline.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request modifies the UI rendering logic in the NativeExecutor.cpp file, focusing on constraining UI layout to PassLayout/'default' and updating the submitUICommands function.

  • Added phaseLayoutID parameter to submitUICommands in native/cocos/renderer/pipeline/custom/NativeExecutor.cpp
  • Implemented check to ensure UI elements are only rendered in the correct pipeline phase
  • Aligned UI rendering behavior with legacy pipeline by constraining to 'default' phase layout
  • Potential impact on rendering of 'additive-light' objects in UI, which will no longer be rendered

@star-e star-e changed the title constrain UI layout to PassLayout/'default' constrain UI phase ID to PassLayout/'default' Aug 15, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e requested a review from minggo August 15, 2024 10:00
@star-e star-e merged commit a705a91 into cocos:v3.8.4 Aug 16, 2024
23 checks passed
@star-e star-e deleted the v3.8.4-pipeline branch August 16, 2024 02:39
@star-e
Copy link
Contributor Author

star-e commented Aug 16, 2024

Also fixing test case render-ui-to-model, render-ui-to-spriteframe on ios platform.
However, the problem might still persists.
https://github.com/cocos/3d-tasks/issues/18404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants