Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reflection probe bake and planar reflection error in editor #17584

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Aug 27, 2024

Fix
https://github.com/cocos/3d-tasks/issues/18470
https://github.com/cocos/3d-tasks/issues/18365

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request addresses issues with reflection probe baking and planar reflection in the editor by modifying the rendering pipeline and probe handling logic.

  • Added enablePlanarReflectionProbe property to CameraConfigs in editor/assets/default_renderpipeline/builtin-pipeline.ts to control planar reflection probe rendering
  • Replaced probeQueue.applyMacro with probeQueue.addToProbeQueue in cocos/rendering/custom/scene-culling.ts for improved reflection probe processing
  • Added new applyMacro method to ProbeHelperQueue class in cocos/rendering/custom/web-pipeline-types.ts
  • Implemented macro application for reflection probe rendering in DeviceRenderScene class in cocos/rendering/custom/executor.ts

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

Comment on lines 1446 to 1450
const renderQueueDesc = sceneCulling.renderQueueIndex.get(this.graphScene.sceneID)!;
const renderQueue = sceneCulling.renderQueues[renderQueueDesc.renderQueueTarget];
const graphSceneData = this.graphScene.scene!;
if (bool(graphSceneData.flags & SceneFlags.REFLECTION_PROBE)) renderQueue.probeQueue.applyMacro();
renderQueue.recordCommands(context.commandBuffer, this._renderPass);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Ensure reflection probe macro is applied and removed correctly

@star-e
Copy link
Contributor Author

star-e commented Aug 27, 2024

image

Bake to Cubemap objects are not included in cubemap, still has problem.

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e requested a review from minggo August 29, 2024 02:16
@minggo minggo merged commit 6fe9ff7 into cocos:v3.8.4 Aug 29, 2024
11 checks passed
yoki0805 pushed a commit to yoki0805/cocos-engine that referenced this pull request Sep 5, 2024
@star-e star-e deleted the v3.8.4-pipeline branch October 14, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants