-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reflection probe bake and planar reflection error in editor #17584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
const renderQueueDesc = sceneCulling.renderQueueIndex.get(this.graphScene.sceneID)!; | ||
const renderQueue = sceneCulling.renderQueues[renderQueueDesc.renderQueueTarget]; | ||
const graphSceneData = this.graphScene.scene!; | ||
if (bool(graphSceneData.flags & SceneFlags.REFLECTION_PROBE)) renderQueue.probeQueue.applyMacro(); | ||
renderQueue.recordCommands(context.commandBuffer, this._renderPass); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Ensure reflection probe macro is applied and removed correctly
Interface Check ReportThis pull request does not change any public interfaces ! |
Fix
https://github.com/cocos/3d-tasks/issues/18470
https://github.com/cocos/3d-tasks/issues/18365
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
This pull request addresses issues with reflection probe baking and planar reflection in the editor by modifying the rendering pipeline and probe handling logic.
enablePlanarReflectionProbe
property toCameraConfigs
ineditor/assets/default_renderpipeline/builtin-pipeline.ts
to control planar reflection probe renderingprobeQueue.applyMacro
withprobeQueue.addToProbeQueue
incocos/rendering/custom/scene-culling.ts
for improved reflection probe processingapplyMacro
method toProbeHelperQueue
class incocos/rendering/custom/web-pipeline-types.ts
DeviceRenderScene
class incocos/rendering/custom/executor.ts