Fix the issue where post-processing modifications after rendering are ineffective. #17586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
475
to
+485
| updateBuffer (bindId: number, vals: number[], layout: string, setData: DescriptorSetData): void { | ||
| const descriptorSet = setData.descriptorSet!; | ||
| const buffer = this.getCurrentBuffer(); | ||
| const uniformKey = `${layout}${bindId}${this.currBuffIdx}`; | ||
| let currUniform = uniformMap.get(uniformKey); | ||
| const currHash = numsHash(vals); | ||
| let currUniform = uniformMap.get(buffer); | ||
| if (!currUniform) { | ||
| currUniform = new Float32Array(vals); | ||
| uniformMap.set(uniformKey, currUniform); | ||
| } | ||
| const destHash = buffHashMap.get(buffer); | ||
| if (destHash !== currHash) { | ||
| currUniform.set(vals); | ||
| buffer.update(currUniform); | ||
| bindGlobalDesc(descriptorSet, bindId, buffer); | ||
| buffHashMap.set(buffer, currHash); | ||
| uniformMap.set(buffer, currUniform); | ||
| } | ||
| currUniform.set(vals); | ||
| buffer.update(currUniform); | ||
| bindGlobalDesc(descriptorSet, bindId, buffer); |
There was a problem hiding this comment.
style: Buffer is now always updated, which may affect performance but ensures consistency
Interface Check ReportThis pull request does not change any public interfaces ! |
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
star-e
approved these changes
Aug 29, 2024
minggo
approved these changes
Aug 29, 2024
yoki0805
pushed a commit
to yoki0805/cocos-engine
that referenced
this pull request
Sep 5, 2024
… ineffective. (cocos#17586) * Fix the issue where post-processing modifications after rendering are ineffective. * Removes the intensity edit slot for bloom effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This pull request modifies the BuiltinPipelineSettings class in the default render pipeline, specifically affecting the bloom intensity property.
editor/assets/default_renderpipeline/builtin-pipeline-settings.ts