-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing sprite set sprite frame with an atlas does not auto add the atlas. #17727
Conversation
… not auto add the atlas.
@cocos-robot run test cases |
Interface Check ReportThis pull request does not change any public interfaces ! |
cocos/2d/components/sprite.ts
Outdated
expectedH = rect.height; | ||
} | ||
if (EDITOR) { | ||
if (this._spriteFrame) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no different than the original logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refined code is ready; you can check the new commit.
@knoxHuang, Please check the result of
Task Details |
@knoxHuang, Please check the result of
Task Details |
Re: #https://github.com/cocos/3d-tasks/issues/10318
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: