Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sprite set sprite frame with an atlas does not auto add the atlas. #17727

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Oct 16, 2024

Re: #https://github.com/cocos/3d-tasks/issues/10318

Changelog

  • Fixing sprite component dragging in a sprite frame with an atlas does not auto add the atlas.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@knoxHuang
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

Interface Check Report

This pull request does not change any public interfaces !

expectedH = rect.height;
}
if (EDITOR) {
if (this._spriteFrame) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no different than the original logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refined code is ready; you can check the new commit.

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

@minggo minggo merged commit 8dfa2b6 into cocos:v3.8.5 Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants