Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: memory leak #20720

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from
Open

bugfix: memory leak #20720

wants to merge 1 commit into from

Conversation

niu2x
Copy link
Contributor

@niu2x niu2x commented Jan 22, 2022

i think CommandBufferGL::setVertexBuffer and CommandBufferGL::setIndexBuffer should do same things.

  1. check weather new value is different from old value.
  2. release old value, retain new value.

there's memory leak in CommandBufferGL::setVertexBuffer if not release old value

@niu2x
bugfix: memory leak
b801115 
we should release old vertex buffer.
@niu2x
Copy link
Contributor Author

niu2x commented Jan 22, 2022

checks fail due to: /usr/bin/ld: cannot find -lXxf86vm.
it's not my fault...

@namka279
Copy link

#20720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLostMyDriversLicense iLostMyDriversLicense iLostMyDriversLicense left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niu2x @namka279 @iLostMyDriversLicense