Skip to content

Commit

Permalink
Create AllUsers Principal and deprecate Anyone Principal (#3091)
Browse files Browse the repository at this point in the history
  • Loading branch information
sam-codaio authored Oct 22, 2024
1 parent 1724cb1 commit 940ab93
Show file tree
Hide file tree
Showing 5 changed files with 66 additions and 7 deletions.
22 changes: 20 additions & 2 deletions dist/bundle.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 20 additions & 2 deletions dist/schema.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions dist/schema.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codahq/packs-sdk",
"version": "1.8.1-prerelease.3",
"version": "1.8.1-prerelease.4",
"license": "MIT",
"workspaces": [
"dev/eslint"
Expand Down
22 changes: 20 additions & 2 deletions schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,12 @@ export interface ObjectSchemaDefinition<K extends string, L extends string>
export enum PrincipalType {
User = 'user',
Group = 'group',
/**
* @deprecated
* @hidden
*/
Anyone = 'anyone',
AllUsers = 'allUsers',
Domain = 'domain',
}

Expand Down Expand Up @@ -1426,22 +1431,35 @@ export interface DomainPrincipal {
/**
* This represents a principal corresponding to anyone
*
* Generally this would apply to an entity where anyone with access to the url can view the item
* Generally this would apply to an entity where anyone with access to the url can view the item.
* Deprecated in favor of {@link AllUsersPrincipal}. Will be removed in a future SDK version.
*
* TODO(sam): Unhide this
* @deprecated
* @hidden
*/
export interface AnyonePrincipal {
type: PrincipalType.Anyone;
}

/**
* This represents a principal corresponding to anyone who has access to the external system.
*
* This corresponds to any user who appears in the sync table with role {@link TableRole.Users}
*
* TODO(sam): Unhide this
* @hidden
*/
export interface AllUsersPrincipal {
type: PrincipalType.AllUsers;
}
/**
* This represents a principal that can be granted access.
*
* TODO(sam): Unhide this
* @hidden
*/
type Principal = UserPrincipal | GroupPrincipal | AnyonePrincipal | DomainPrincipal;
type Principal = UserPrincipal | GroupPrincipal | AnyonePrincipal | DomainPrincipal | AllUsersPrincipal;

/**
* The type of permission.
Expand Down

0 comments on commit 940ab93

Please sign in to comment.