Skip to content

Commit

Permalink
Require node20+ for SDK development (#3144)
Browse files Browse the repository at this point in the history
Since 18 is broken at the moment and we're planning to migrate to 20 soon, seems like we might
as well commit and force SDK-based development to use node 20+
  • Loading branch information
dweitzman-codaio authored Jan 6, 2025
1 parent b43947f commit aaa6273
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v20
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,17 @@ This changelog keeps track of all changes to the Packs SDK. We follow convention

## [Unreleased]

### Changed

- SDK requires node version 20 or higher

## [1.8.6] - 2024-12-13

### Changed

- Certain ingestion-specific fields were renamed.
- Added `SyncStateService` to retrieve the row sync state in Coda Brain.


## [1.8.5] - 2024-12-04

### Changed
Expand Down Expand Up @@ -859,5 +862,4 @@ await myHelper(context);
[1.8.3]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.8.3
[1.8.4]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.8.4
[1.8.5]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.8.5
[1.8.6]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.8.6
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dev/eslint"
],
"engines": {
"node": ">=18.0.x",
"node": ">=20.0.x",
"pnpm": "9.15.0"
},
"main": "dist/index.js",
Expand Down
6 changes: 4 additions & 2 deletions setup-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ if [[ "$(uname -s)" == "Darwin" ]] && [[ "$(arch)" == "arm64" ]]; then
export PATH="/opt/homebrew/bin:${PATH}"
fi

export PATH=${BASEDIR}/build/node/bin:${BASEDIR}/node_modules/.bin:${BASEDIR}/.pnpm_install/bin:${PATH}

if command -v nvm &> /dev/null
then
# Gets version from .nvmrc
nvm use
fi


export PATH=${BASEDIR}/.pnpm_install/bin:${BASEDIR}/build/node/bin:${BASEDIR}/node_modules/.bin:${PATH}
export NODE_OPTIONS="--no-node-snapshot ${NODE_OPTIONS}"

0 comments on commit aaa6273

Please sign in to comment.