Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Playback Speed & Force Volume don't work. #1624

Closed
starobots opened this issue Mar 18, 2023 · 29 comments
Closed

Force Playback Speed & Force Volume don't work. #1624

starobots opened this issue Mar 18, 2023 · 29 comments
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.)

Comments

@starobots
Copy link

'Hidden on video page' doesn't work at vr.4.20, patch March 17th.
'Force playback speed' doesn't work, the speed control shortcut is working well.
'Force volume' doesn't work.

@starobots starobots added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Mar 18, 2023
@ImprovedTube
Copy link
Member

hi! @starobots 1. is fixed #1621 can't recreated 2. & 3.

@ImprovedTube ImprovedTube added the Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle) label Mar 18, 2023
@Ac5000
Copy link

Ac5000 commented Mar 19, 2023

I can second the "Force playback speed" not working correctly anymore. (Been like this for >~5 days? I don't remember exactly when it started.)

Firefox V111.0
Addon V4.1 (from the extension store)

Videos will load without any speed changes/forces.
The force-playback speed will work/take hold if you set the speed in the addon after the/multiple tabs of video are already opened and playing.

I've also noticed that sometime the videos will load/start playing with the speed forces working as expected. But it's not consistent and I haven't found what causes some to work and others to not.

@IonDrako
Copy link

hi! @starobots 1. is fixed #1621 can't recreated 2. & 3.

Is there a timeframe until the chrome extension gets said fix?

@ImprovedTube
Copy link
Member

@Ac5000 @starobots @IonDrako
Speed & volume should work flawless / never break from Youtube changes.
So it is mysterious. Somebody said it worked well since toggling the switches 🤨

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 21, 2023

Speed & volume

we can make them persistent and retry at need, but i have not seen a single issue with them yet

  • so you can open the browser console to show us the errors

( 4.1 had some unlucky bugs. Might be better now
but firefox allows going back to 4.1 with 1 click for testing)

@PoorChameleon
Copy link

The forced volume not working (or very rarely working) should hopefully be reproducible with this settings file

@ImprovedTube
Copy link
Member

🤔🤔 @Ac5000 so you probably noticed we have disabled speed for music, unless you click that too

@Ac5000
Copy link

Ac5000 commented Mar 24, 2023

🤔🤔 @Ac5000 so you probably noticed we have disabled speed for music, unless you click that too

I have that enabled as well. (Wasn't sure how the extension determined "music". I assume it's tag based, but had concerns some videos might have that tag in error.)

  • Firefox has updated to V111.0.1 (64-bit)
  • Improved YouTube Extension is now V4.4

Still having the issue with my speed override not working when videos are opened. I wasn't affected by the Force Volume issue that I've noticed. (During my first post or this one.)

If I toggle the "Forced playback speed..." switch, or enter the "Playback speed" number, all videos currently opened and paused will start playing at the expected override speed.

Unfortunately, the problem is still inconsistent. It seems like sometimes after I've watched a few videos after manually clicking the button, videos will start opening with the playback speed forced as expected.

I do have a couple other extensions that work on YouTube:

  • SponsorBlock for YouTube
  • uBlock Origin

I've checked the settings in those to see if I could find anything that might be conflicting. I haven't gone as far as disabling them to see if the issue goes away yet though. I'm worried, with the inconsistency of the problem, I won't be able to tell if I do disable those.

@ImprovedTube Is there anything I could check to help you troubleshoot the issue? Not sure if there's any logs or console output that I could look into to see if there's some sort of error that I could point you towards.

Thank you for taking the time to look into this for me. It's greatly appreciated! Let me know how I can help and I'll try my best.

@PoorChameleon
Copy link

Just confirming that the forced volume not working still exists on 4.4. Reverting to 4.0.17.1 makes it work again.

@DerP4si
Copy link

DerP4si commented Mar 24, 2023

Just confirming that the forced volume not working still exists on 4.4. Reverting to 4.0.17.1 makes it work again.

How do you go back? I've the same speed issue :/

@PoorChameleon
Copy link

How do you go back? I've the same speed issue :/

If you're using Firefox you can go here, find the version you want and click download file. After doing so you might want to go into the extension settings and disable automatic updates for now.

I don't know if it's possible with other browsers, unless you load the extension manually from an earlier commit on GitHub.

@DerP4si
Copy link

DerP4si commented Mar 24, 2023

hmm i'm on chrome and it seems there are no older versions/ its not possible to get them that easy...

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 24, 2023

thank you! :) @Ac5000 @PoorChameleon;
We can fix it today.

If you're using Firefox

on chrome ... older versions ... not possible to get them that easy


Let me know how I can help and I'll try my best.

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 24, 2023

Wasn't sure how the extension determined "music".

worth trying yet @Ac5000 & might inspire users to enhance it, when noticing exceptions to the rules later,
just went ahead to write about it:

#1636

@DerP4si
Copy link

DerP4si commented Mar 24, 2023

Huh rolling back to 4.1 had no effect on the issue... Might be a YouTube bug/problem? Maybe they made some api changes?

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 25, 2023

hi @DerP4si, 4.0.1? @PoorChameleon said 4.0.17 works... while @Ac5000 said 4.1 is also broken
so we can test all in between as described above. Chrome 110 made Memory saving a default since ~ Feburary22

@Ac5000
Copy link

Ac5000 commented Mar 25, 2023

  • generally, when an error happens: F12 Checking for browser-console errors referring to our scripts => typos will usually be found. (didnt find this time)

I tried loading up a couple different videos, toggling the force speed, and watching the log. The errors and warnings below are the best representation of what I saw as common between different tabs/videos. I unfortunately don't know JS so I don't know what to look for specifically. Let me know if you have something else you'd like me to try for you.

Series of steps used to get these errors/warnings:

  1. Open video in new tab.
  2. Press play
  3. Video runs at normal (1x) speed.
  4. Toggle force speed (2.5x)
  5. Video plays at 2.5x speed
  6. Refresh the page.
  7. Press play
  8. Video plays at normal (1x) speed.
  9. Capture errors and warnings from the F12 console.

Source map error: Error: request failed with status 404 Resource URL: https://www.youtube.com/s/desktop/f8ad2d78/jsbin/custom-elements-es5-adapter.vflset/custom-elements-es5-adapter.js Source Map URL: blaze-out/k8-opt/bin/third_party/javascript/custom_elements/fast-shim.js.sourcemap
Source map error: Error: request failed with status 404 Resource URL: https://www.youtube.com/s/desktop/f8ad2d78/jsbin/webcomponents-sd.vflset/webcomponents-sd.js Source Map URL: blaze-out/k8-opt/bin/third_party/javascript/polymer/v2/webcomponentsjs/webcomponents-sd.js.sourcemap
Some cookies are misusing the recommended “SameSite“ attribute 19
Source map error: Error: request failed with status 404 Resource URL: https://www.youtube.com/s/desktop/f8ad2d78/jsbin/web-animations-next-lite.min.vflset/web-animations-next-lite.min.js Source Map URL: web-animations-next-lite.min.js.map
MouseEvent.mozPressure is deprecated. Use PointerEvent.pressure instead. base.js:2182:347
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at data:text/plain;base64,Cg==. (Reason: CORS request not http).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://googleads.g.doubleclick.net/pagead/id. (Reason: CORS request did not succeed). Status code: (null).
Loading failed for the <script> with source “https://static.doubleclick.net/instream/ad_status.js”. watch:1:1 WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. JKI-Neg5ZU5KK1Xo01VWGlJ1rRlPViDIC-PSh86zliQ.js line 2 > eval line 2976 > eval line 1 > eval line 1 > eval:1:118
The resource at “https://i.ytimg.com/generate_204” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. watch
The resource at “https://rr2---sn-hxugvoxupoj-poql.googlevideo.com/generate_204” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. watch
The resource at “https://rr2---sn-hxugvoxupoj-poql.googlevideo.com/generate_204?conn2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. watch

@DerP4si
Copy link

DerP4si commented Mar 25, 2023

Yip, sry i misread that... 4.0.17 works just fine... Going to post thrown errors of 4.1+ later this day.

@ImprovedTube
Copy link
Member

thanks @Ac5000! the errors dont seem related to the issue. could still test with only our extension running in incognito mode but probably get no errors then

if you guys just try these 4 version then we can at least say which of our changes triggers the issue

you can check these 4: HEAD@%7B2023-01-22%7D = 1.zip

HEAD@%7B2023-02-13%7D = 2.zip

HEAD@%7B2023-02-23%7D = 3.zip

HEAD@%7B2023-02-27%7D = 4.zip

@DerP4si
Copy link

DerP4si commented Mar 25, 2023

The bug seems to be in 3+.zip. In 2.zip it works as espected.

@fernplant
Copy link

I tested the 4 zipped versions and

  • 1 and 2 seem to have no issue with forced playback speed or speed keyboard shortcuts.
  • 3 does not force the proper playback speed but speed keyboard shortcut works
  • 4 does work with forced playback speed but keyboard speed shortcuts do not work

Using Chrome 111.0.5563.64 (Official Build) (arm64)

@ImprovedTube ImprovedTube changed the title Hidden on Video Page and Force Playback Speed and Force Volume doesn't work. Force Playback Speed & Force Volume doesn't work. Mar 25, 2023
@ImprovedTube ImprovedTube changed the title Force Playback Speed & Force Volume doesn't work. Force Playback Speed & Force Volume don't work. Mar 25, 2023
@Ac5000
Copy link

Ac5000 commented Mar 25, 2023

could still test with only our extension running in incognito mode but probably get no errors then

Same steps as before, just in private browsing with all other extensions disabled. However, the force speed not working when I refreshed was much more inconsistent in this test. It did still fail to force the speed to 2.5x when I refreshed several times though.

Source map error: Error: request failed with status 404 Resource URL: https://www.youtube.com/s/desktop/f8ad2d78/jsbin/custom-elements-es5-adapter.vflset/custom-elements-es5-adapter.js Source Map URL: blaze-out/k8-opt/bin/third_party/javascript/custom_elements/fast-shim.js.sourcemap

Source map error: Error: request failed with status 404 Resource URL: https://www.youtube.com/s/desktop/f8ad2d78/jsbin/webcomponents-sd.vflset/webcomponents-sd.js Source Map URL: blaze-out/k8-opt/bin/third_party/javascript/polymer/v2/webcomponentsjs/webcomponents-sd.js.sourcemap

Some cookies are misusing the recommended “SameSite“ attribute 7

Source map error: Error: request failed with status 404 Resource URL: https://www.youtube.com/s/desktop/f8ad2d78/jsbin/web-animations-next-lite.min.vflset/web-animations-next-lite.min.js Source Map URL: web-animations-next-lite.min.js.map

Partitioned cookie or storage access was provided to “https://tpc.googlesyndication.com/sodar/5k7CCto5.html” because it is loaded in the third-party context and dynamic state partitioning is enabled.

MouseEvent.mozPressure is deprecated. Use PointerEvent.pressure instead. base.js:2182:347

WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. t4_aWeuLa_BO9IGQ3R3HcB0TaFNoER_W7PQrl5RFgV0.js line 2 > eval line 5232 > eval line 1 > eval line 1 > eval:1:120

Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted. mutations.js:20:18

XHRGEThttps://www.googleapis.com/youtube/v3/videos?part=snippet&id=FGA044GLz0Q&key=AIzaSyCXRRCFwKAXOiF1JkUBmibzxJF1cPuKNwA [HTTP/2 400 Bad Request 54ms]

The resource at “https://i.ytimg.com/generate_204” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. watch

The resource at “https://rr3---sn-hxugvoxupoj-poql.googlevideo.com/generate_204” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. watch

The resource at “https://rr3---sn-hxugvoxupoj-poql.googlevideo.com/generate_204?conn2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. watch

WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. 23K_wv65UPCiABIo6r4TLz_7ITKDRTsdN0481kHWjEo.js line 2 > eval line 7204 > eval line 1 > eval line 1 > eval:1:116

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 25, 2023

Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted. mutations.js:20:18

Hi @Ac5000, there we have the first one about ImprovedTube. However not about this issue

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 25, 2023

The bug seems to be in 3+.zip. In 2.zip it works as espected.

thanks, i knew this experiment would break something 🙈, more precisely ImprovedTube.initPlayer()
was just optimistic since we dont get a Pull Request every day & forgot.

https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/360b43c738b0fa4514ba10d13fb6ff2ef803e225/content-scripts/website-context/youtube-features/player.js#L13

(avoid experiments with global variables / without tracing them @MohamedLebda )

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 25, 2023

you can now confirm, if you want, that the repo master is fixed,
https://github.com/code-for-charity/ImprovedTube-for-YouTube/archive/refs/heads/master.zip
@Ac5000 @DerP4si @PoorChameleon @starobots

unfortunately it takes approximately till tuesday for webstores to publish this

@ImprovedTube ImprovedTube removed Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle) Bug Bug or required update after YouTube changes labels Mar 25, 2023
@DerP4si
Copy link

DerP4si commented Mar 25, 2023

Yip.... thx for the fast fix! And thx for making this extension <3

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 27, 2023

thanks again @fernplant

  • 4 .... keyboard speed shortcuts do not work

cant find this besides our shortcuts can always be be a bit confusing, as they will play for demo once when you set them, but then only really work after the next reload.

@ImprovedTube ImprovedTube added the Bug Bug or required update after YouTube changes label Mar 27, 2023
@starobots
Copy link
Author

Hi, after few days usage, the patch is 4.6 or 4.6.1 right now.
And this is the report.
The youtube headbar can 'hidden on video page' and 'hover on video page'.
The 'force playback speed' feature works well.

Thanks for the developing and updating. O/

ImprovedTube added a commit that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.)
Projects
None yet
Development

No branches or pull requests

7 participants