-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force Playback Speed & Force Volume don't work. #1624
Comments
hi! @starobots 1. is fixed #1621 can't recreated 2. & 3. |
I can second the "Force playback speed" not working correctly anymore. (Been like this for >~5 days? I don't remember exactly when it started.) Firefox V111.0 Videos will load without any speed changes/forces. I've also noticed that sometime the videos will load/start playing with the speed forces working as expected. But it's not consistent and I haven't found what causes some to work and others to not. |
Is there a timeframe until the chrome extension gets said fix? |
@Ac5000 @starobots @IonDrako |
we can make them persistent and retry at need, but i have not seen a single issue with them yet
( 4.1 had some unlucky bugs. Might be better now |
The forced volume not working (or very rarely working) should hopefully be reproducible with this settings file |
🤔🤔 @Ac5000 so you probably noticed we have disabled speed for music, unless you click that too |
I have that enabled as well. (Wasn't sure how the extension determined "music". I assume it's tag based, but had concerns some videos might have that tag in error.)
Still having the issue with my speed override not working when videos are opened. I wasn't affected by the Force Volume issue that I've noticed. (During my first post or this one.) If I toggle the "Forced playback speed..." switch, or enter the "Playback speed" number, all videos currently opened and paused will start playing at the expected override speed. Unfortunately, the problem is still inconsistent. It seems like sometimes after I've watched a few videos after manually clicking the button, videos will start opening with the playback speed forced as expected. I do have a couple other extensions that work on YouTube:
I've checked the settings in those to see if I could find anything that might be conflicting. I haven't gone as far as disabling them to see if the issue goes away yet though. I'm worried, with the inconsistency of the problem, I won't be able to tell if I do disable those. @ImprovedTube Is there anything I could check to help you troubleshoot the issue? Not sure if there's any logs or console output that I could look into to see if there's some sort of error that I could point you towards. Thank you for taking the time to look into this for me. It's greatly appreciated! Let me know how I can help and I'll try my best. |
Just confirming that the forced volume not working still exists on 4.4. Reverting to 4.0.17.1 makes it work again. |
How do you go back? I've the same speed issue :/ |
If you're using Firefox you can go here, find the version you want and click download file. After doing so you might want to go into the extension settings and disable automatic updates for now. I don't know if it's possible with other browsers, unless you load the extension manually from an earlier commit on GitHub. |
hmm i'm on chrome and it seems there are no older versions/ its not possible to get them that easy... |
thank you! :) @Ac5000 @PoorChameleon;
|
Huh rolling back to 4.1 had no effect on the issue... Might be a YouTube bug/problem? Maybe they made some api changes? |
hi @DerP4si, 4.0.1? @PoorChameleon said 4.0.17 works... while @Ac5000 said 4.1 is also broken |
you can check these 4: https://github.com/code-for-charity/ImprovedTube-for-YouTube/tree/HEAD@%7B2023-02-13%7D = 2.zip https://github.com/code-for-charity/ImprovedTube-for-YouTube/tree/HEAD@%7B2023-02-23%7D = 3.zip https://github.com/code-for-charity/ImprovedTube-for-YouTube/tree/HEAD@%7B2023-02-27%7D = 4.zip thanks |
I tried loading up a couple different videos, toggling the force speed, and watching the log. The errors and warnings below are the best representation of what I saw as common between different tabs/videos. I unfortunately don't know JS so I don't know what to look for specifically. Let me know if you have something else you'd like me to try for you. Series of steps used to get these errors/warnings:
|
Yip, sry i misread that... 4.0.17 works just fine... Going to post thrown errors of 4.1+ later this day. |
thanks @Ac5000! the errors dont seem related to the issue. could still test with only our extension running in incognito mode but probably get no errors then if you guys just try these 4 version then we can at least say which of our changes triggers the issue
|
The bug seems to be in 3+.zip. In 2.zip it works as espected. |
I tested the 4 zipped versions and
Using Chrome 111.0.5563.64 (Official Build) (arm64) |
Same steps as before, just in private browsing with all other extensions disabled. However, the force speed not working when I refreshed was much more inconsistent in this test. It did still fail to force the speed to 2.5x when I refreshed several times though.
|
Hi @Ac5000, there we have the first one about ImprovedTube. However not about this issue |
thanks, i knew this experiment would break something 🙈, more precisely ImprovedTube.initPlayer() (avoid experiments with global variables / without tracing them @MohamedLebda ) |
you can now confirm, if you want, that the repo master is fixed, unfortunately it takes approximately till tuesday for webstores to publish this |
Yip.... thx for the fast fix! And thx for making this extension <3 |
thanks again @fernplant
cant find this besides our shortcuts can always be be a bit confusing, as they will play for demo once when you set them, but then only really work after the next reload. |
Hi, after few days usage, the patch is 4.6 or 4.6.1 right now. Thanks for the developing and updating. O/ |
'Hidden on video page' doesn't work at vr.4.20, patch March 17th.
'Force playback speed' doesn't work, the speed control shortcut is working well.
'Force volume' doesn't work.
The text was updated successfully, but these errors were encountered: