Update player.js consolidate subtitle font settings to subtitlesUserS…

[raszpl]

subtitlesUserSettings

SUBTITLES FONT FAMILY
SUBTITLES FONT COLOR
SUBTITLES FONT SIZE
SUBTITLES BACKGROUND COLOR
SUBTITLES BACKGROUND OPACITY
SUBTITLES WINDOW COLOR
SUBTITLES WINDOW OPACITY
SUBTITLES CHARACTER EDGE STYLE
SUBTITLES FONT OPACITY

[ImprovedTube]

yay consolidation!

default = {
...
},

only needed youtube's defaults yet when our menu is called (index.html)
(every feature (or group of feature's )code can depend being enabled (avoiding bugs and cpu). ( if( alwaysRepeat ){ repeat();}
if (ImprovedTube.storage.always_show_progress_bar === true) {ImprovedTube.showProgressBar();} if(this.storage.description === "sidebar"){this.descriptionSidebar();} if(this.storage.undo_the_new_sidebar === true){this.undoTheNewSidebar();} )

  case 'number':
  case 'color':
  case 'fraction':

( Did #2251 also make you think of dynamically providing unknown Features & GUI? for (experimentsflags in trashbin) { experimentflag=false } )

---

Btw, setting the repo to manifest3 now, so we might notice bugs. And want to upload it for beta testing, before it has to go live soon; in May if we want to keep the Googles featured badge.

[raszpl]

default = {
...
},

only needed youtube's defaults yet when our menu is called

its code documentation, so someone reading this code in a year can immediately know what its doing

Btw, setting the repo to manifest3 now

oh, so thats why after updating today it forced itself into Vivaldi side panel

[ImprovedTube]

@raszpl

code documentation

💡💡

oh, so thats why after updating today it forced itself into Vivaldi side panel

Vivaldi prefers sidepanels?
made it a toggle in general section for now actually.

Besides (other topic:) maybe we should enable chrome's sidepanel at new installations by default. So one can't accidentally click outside of the popup (and less scrolling). Since our sessions are long/intensive in average. So people will accidentally click outside of the popup a lot, and stay a little stressed not to lose the focus/navigation again. - Or maybe no side panel, because, while on a YouTube tab, the popup could stay, not to change the width of www-youtube-com and if the extension icon is clicked while not on youtube, then we should provide a full tab with an embedded player & history (ordered by recency*frequency, most watched categories & channels like https://github.com/code-charity/History-Manager's columns but for youtube.) ( and maybe with some code from https://github.com/soufianesakhi/youtube-playlist-helper etc ), does this sound good?

[raszpl]

oh, so thats why after updating today it forced itself into Vivaldi side panel

Vivaldi prefers sidepanels? made it a toggle in general section for now actually.

"ImprovedTube: Browser Sidepanel" ? doesnt seem to do anything for Vivaldi. Simply restarting the extension (so background.js reruns) seems to plop it into the sidebar

I can manually remove it from Toolbar, but on next browser/extension restart its back there again. It also force pops out/goes active on extension restart.

since 4930 there is tons of
Uncaught (in promise) Error: Could not establish connection. Receiving end does not exist. chrome-extension://l…gki/background.js:1
in menu popup console. And I mean Im currently at 1300 copies of this error on my ~1 hour browsing session. After restarting extension its already at ~200 errors.

Besides (other topic:) maybe we should enable chrome's sidepanel at new installations by default.

it seems to be already default on Vivaldi for some stupid Vivaldi reason :), and It seems to be one same permanent session. Closing Toolbar/Side Panel and opening it back again I get back to same panel remembering my search/opened Section.

embedded player & history (ordered by recency*frequency, most watched categories & channels

Analyzer is broken currently

does this sound good?

Doesnt sound like something I would personally use. My YT activity is limited to https://www.youtube.com/feed/subscriptions

[ImprovedTube]

hi! @raszpl

in menu popup console. And I mean Im currently at 1300 copies of this error on my ~1 hour browsing session. After restarting extension its already at ~200 errors.

also had this when running mainfest3 before in 2022

one same permanent session

interesting!

My YT activity is limited to youtube.com/feed/subscriptions

so https://www.youtube.com/feed/history is rare? (i think remembering/learning often involves repetition, at least once)