Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar fix #2663

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Sidebar fix #2663

merged 3 commits into from
Nov 9, 2024

Conversation

dodieboy
Copy link
Member

@dodieboy dodieboy commented Nov 7, 2024

This should fix #2648 and fix the feature that I added in #1356 cause by Youtube changes

@dodieboy
Copy link
Member Author

dodieboy commented Nov 7, 2024

wait, the issue is not fix. Sry, I doing more testing now

@dodieboy
Copy link
Member Author

dodieboy commented Nov 7, 2024

Now, i can only limit the auto size to when you enable "hide sidebar", then it resize primary div like what i wanted in #1356.
To make it look like what i wanted back then, I have to add some js code which will make it that user need to refresh the page

@dodieboy
Copy link
Member Author

dodieboy commented Nov 7, 2024

The cause of issue 2648 is that there is no max-width set for .primary div, but there is no way for me to know the side of the width of the current sidebar size for me to set a calc for .primary div unless I did it in js code

@ImprovedTube
Copy link
Member

#1356 remembered! yay

@ImprovedTube
Copy link
Member

hide sidebar was added later. Previously related videos: hidden did also hide the sidebar

@ImprovedTube
Copy link
Member

looking forward!

@dodieboy
Copy link
Member Author

dodieboy commented Nov 9, 2024

Now the auto width I only set for hide sidebar (as of this pull request you) because if I want to make auto width not limit to hide sidebar, I need to add more check to check is there any element(live chat, donation box) in the sidebar, which need to add js code, which I have no time to develop it

@ImprovedTube ImprovedTube merged commit b723145 into code-charity:master Nov 9, 2024
1 check passed
@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 9, 2024

forgot to merge earlier

@ImprovedTube
Copy link
Member

so will it only fix #2648 (a bit rare) or also maybe take away the feature for somebody where it looks good? (many people are used to how it is).

@ImprovedTube
Copy link
Member

busy

may your work be meaningful and fun! :) @dodieboy

@dodieboy
Copy link
Member Author

so will it only fix #2648 (a bit rare) or also maybe take away the feature for somebody where it looks good? (many people are used to how it is).

I believe this feature is not working for a few months, and since no one submit a issue, I believe everyone thinks it was a YouTube feature 😄😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar auto sizing CSS breaks page zoom
2 participants