-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar fix #2663
Sidebar fix #2663
Conversation
wait, the issue is not fix. Sry, I doing more testing now |
Now, i can only limit the auto size to when you enable "hide sidebar", then it resize primary div like what i wanted in #1356. |
The cause of issue 2648 is that there is no max-width set for .primary div, but there is no way for me to know the side of the width of the current sidebar size for me to set a calc for .primary div unless I did it in js code |
#1356 remembered! yay |
|
looking forward! |
Now the auto width I only set for hide sidebar (as of this pull request you) because if I want to make auto width not limit to hide sidebar, I need to add more check to check is there any element(live chat, donation box) in the sidebar, which need to add js code, which I have no time to develop it |
forgot to merge earlier |
so will it only fix #2648 (a bit rare) or also maybe take away the feature for somebody where it looks good? (many people are used to how it is). |
may your work be meaningful and fun! :) @dodieboy |
I believe this feature is not working for a few months, and since no one submit a issue, I believe everyone thinks it was a YouTube feature 😄😄 |
This should fix #2648 and fix the feature that I added in #1356 cause by Youtube changes