Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ryan/sign up/feat/add educator role to sign up #63252

Draft
wants to merge 19 commits into
base: staging
Choose a base branch
from
Draft

Ryan/sign up/feat/add educator role to sign up #63252

wants to merge 19 commits into from

Conversation

drizco
Copy link
Contributor

@drizco drizco commented Jan 10, 2025

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@drizco drizco force-pushed the ryan/sign-up/feat/add-educator-role-to-sign-up branch 4 times, most recently from 1b7fdaa to 6da56c0 Compare January 13, 2025 19:21
nicklathe and others added 18 commits January 13, 2025 15:54
@nicklathe @drizco
Add educator_type to User serialized_attrs
be7d8d9 
Signed-off-by: Nick Lathe <[email protected]>
@nicklathe @drizco
Add policy with set of allowed educator types
c0a67d9
@nicklathe @drizco
Change type -> role
e435def
@nicklathe @drizco
Add comment for new key in serialized_attr
c5b6d2b
@drizco
feat: add constant for educator roles
9ad5604
@drizco
feat: validate educator_role is either undefined or one of the allowe…
4bd87d8 
…d educator roles
@drizco
feat: add dropdown with educator roles to finish sign up for teacher …
0c75899 
…account
@drizco
feat: add environment var that turns off statsig local mode
f0866fd 
fix: use webpack to set variable
@drizco
feat: show/hide input and enable/disable form based on educator_role …
614eab6 
…experiment
@drizco
refactor: use css to add required asterisk so rtl language works the …
507a629 
…same as other input labels
@drizco
refactor: remove new line and unnecessary div
c4d198a
@drizco
feat: validate that educator_role is only set for teacher users
2132702
@drizco
test: add tests for educator_role validation on the user model
85fb9e1
@drizco
feat: ensure teachers with an educator_role can downgrade to student …
963a476 
…users and retain their educator_role in case they change back to teachers
@drizco
fix: tests were passing but console was full of warnings that state w…
874a67f 
…as being set async, so adding waitFor on each initial render
@drizco
refactor: move fetchStub creation and restore to beforeEach and after…
fc9a977 
…Each
@drizco
test: add tests for educator role experiment
cb20389
@drizco
fix: fixes semantic html error where a p tag had a child div
208bad0
@drizco drizco force-pushed the ryan/sign-up/feat/add-educator-role-to-sign-up branch from 6da56c0 to 208bad0 Compare January 13, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drizco @nicklathe